Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committer: support use as flow #644

Closed
ennru opened this Issue Nov 16, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@ennru
Copy link
Member

ennru commented Nov 16, 2018

As a follow-up on #619 and #622:

The new Committer.sink should even support use as a flow which is required for Lagom to use it.

Lagom's current committing logic:

https://github.com/lagom/lagom/blob/5259f696b61fd939280b5cf1bc3f1aa6f9bcdfd7/service/core/kafka/client/src/main/scala/com/lightbend/lagom/internal/broker/kafka/KafkaSubscriberActor.scala#L107-L111

@ennru

This comment has been minimized.

Copy link
Member Author

ennru commented Nov 19, 2018

Fixed with #647

@ennru ennru closed this Nov 19, 2018

@ennru ennru added this to the 1.0-M2 milestone Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.