Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions benchmarks #481

Merged
merged 3 commits into from May 29, 2018

Conversation

Projects
None yet
2 participants
@seglo
Copy link
Contributor

commented May 28, 2018

Benchmarks for reactive-kafka transactional support. I also included a docker-compose.yml file with up-to-date community Apache Kafka docker images that can be used with the tests.

@seglo

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2018

Resolves issue #461

@seglo

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2018

There's a failure happening in ReconnectSpec, but it doesn't look related.

https://travis-ci.org/akka/reactive-kafka/jobs/384851107#L1312

FYI: @2m, @ennru

- "9092:9092"
environment:
# On Mac you may need to change `localhost` in KAFKA_ADVERTISED_LISTENERS to the ip/host of your docker machine ip
KAFKA_ADVERTISED_LISTENERS: INSIDE://localhost:9092,OUTSIDE://localhost:9094

This comment has been minimized.

Copy link
@2m

2m May 29, 2018

Member

Nice. I was playing around with Kafka in docker containers as well and noticed that the KAFKA_ADVERTISED_HOST_NAME is deprecated.

@2m 2m referenced this pull request May 29, 2018

Closed

Failed: ReconnectSpec #474

@2m

2m approved these changes May 29, 2018

Copy link
Member

left a comment

LGTM. We need to start running these benchmarks periodically sooner rather than later. :)

@2m 2m merged commit c8c5421 into akka:master May 29, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
typesafe-cla-validator All users have signed the CLA
Details

@2m 2m added this to the 0.21 milestone May 29, 2018

@seglo

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2018

Thanks. Yeah, I think running the benchmarks will also reveal more instances of transient failures we've been seeing (I just found another one I'll log an issue for).

BTW, I added another commit for some comments cleanup I did this morning: #483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.