Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer committable over commitable #645

Merged
merged 3 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@ennru
Copy link
Member

commented Nov 16, 2018

I noticed Producer.commitableSink used single-t spelling opposed to all other things in Alpakka Kafka.
Added Producer.committableSink variants and deprecated the existing.

@ennru ennru force-pushed the ennru:ennru_rename-to-committable branch from 909bb0f to 334e51c Nov 21, 2018

@ennru ennru modified the milestone: 1.0-M2 Dec 3, 2018

@ennru ennru force-pushed the ennru:ennru_rename-to-committable branch from 334e51c to 757fdf5 Dec 6, 2018

@ennru ennru added this to the 1.0-M2 milestone Dec 6, 2018

*
* Supports sharing a Kafka Producer instance.
*/
def commitableSink[K, V](

This comment has been minimized.

Copy link
@2m

2m Dec 7, 2018

Member

Missing deprecation annotation

@2m
Copy link
Member

left a comment

LGTM. Just a missing deprecation annotation.

@2m

2m approved these changes Dec 7, 2018

Copy link
Member

left a comment

LGTM

@2m 2m merged commit da1257f into akka:master Dec 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@ennru ennru deleted the ennru:ennru_rename-to-committable branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.