Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync up Kafka version used in embedded kafka; communicate exceptions from subscribing #772

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@2m
Copy link
Member

commented Apr 19, 2019

Without this Kafka server artifacts are mismatched when using coursier and every test that uses EmbeddedKafka fails with:

[info] TransactionsSpec:
[info] akka.kafka.scaladsl.TransactionsSpec *** ABORTED *** (255 milliseconds)
[info]   java.lang.NoSuchMethodError: scala.Predef$.refArrayOps([Ljava/lang/Object;)Lscala/collection/mutable/ArrayOps;
[info]   at kafka.cluster.EndPoint$.<init>(EndPoint.scala:32)
[info]   at kafka.cluster.EndPoint$.<clinit>(EndPoint.scala)
[info]   at kafka.server.Defaults$.<init>(KafkaConfig.scala:68)
[info]   at kafka.server.Defaults$.<clinit>(KafkaConfig.scala)
[info]   at kafka.server.KafkaConfig$.<init>(KafkaConfig.scala:781)
[info]   at kafka.server.KafkaConfig$.<clinit>(KafkaConfig.scala)
[info]   at net.manub.embeddedkafka.EmbeddedKafkaSupport.startKafka(EmbeddedKafka.scala:670)
[info]   at net.manub.embeddedkafka.EmbeddedKafkaSupport.startKafka$(EmbeddedKafka.scala:661)
[info]   at net.manub.embeddedkafka.EmbeddedKafka$.startKafka(EmbeddedKafka.scala:45)
[info]   at net.manub.embeddedkafka.EmbeddedKafkaSupport.startKafka(EmbeddedKafka.scala:695)
[info]   at net.manub.embeddedkafka.EmbeddedKafkaSupport.startKafka$(EmbeddedKafka.scala:690)
[info]   at net.manub.embeddedkafka.EmbeddedKafka$.startKafka(EmbeddedKafka.scala:45)
[info]   at net.manub.embeddedkafka.EmbeddedKafka$.start(EmbeddedKafka.scala:71)
[info]   at akka.kafka.testkit.scaladsl.EmbeddedKafkaLike.setUp(KafkaSpec.scala:46)
...

And eviction warnings show:

[warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[warn]  * org.apache.kafka:kafka_2.12:2.1.1 is selected over 2.0.0
[warn]      +- com.typesafe.akka:akka-stream-kafka-testkit_2.12:1.0.1+25-6cc64424 (depends on 2.1.1)
[warn]      +- net.manub:scalatest-embedded-kafka_2.12:2.0.0      (depends on 2.0.0)
@ennru

ennru approved these changes Apr 20, 2019

Copy link
Member

left a comment

Is the Schemaregistry always used with EmbeddedKafka now?
Would the docs need an update for that? https://doc.akka.io/docs/alpakka-kafka/current/testing.html#testing-with-avro-and-schema-registry

LGTM, otherwise - good to change to the new organization id.

@2m

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

Is the Schemaregistry always used with EmbeddedKafka now?

Nope, they are still separate artifacts. The package change was only for classes from the schemaregistry artifact.

@2m 2m force-pushed the 2m:wip-sync-kafka-versions-2m branch from 3c74e83 to efbdf2d May 7, 2019

2m added some commits Apr 19, 2019

@2m 2m force-pushed the 2m:wip-sync-kafka-versions-2m branch from efbdf2d to ae18d78 May 8, 2019

@ennru ennru changed the title Sync up Kafka version used in embedded kafka Sync up Kafka version used in embedded kafka; communicate exceptions from subscribing May 8, 2019

@2m 2m added this to the 1.0.3 milestone May 8, 2019

@2m 2m merged commit 5afb78e into akka:master May 8, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@2m 2m deleted the 2m:wip-sync-kafka-versions-2m branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.