Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable testkit settings when waiting for the desired cluster state #786

Merged
merged 7 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@2m
Copy link
Member

commented May 6, 2019

Purpose

This PR adds TestKit configuration, that allows to configure the amount of time testkit waits until the desired Kafka cluster state is reached.

References

Previously such timeouts where specified in the code, and would be too short in Travis: https://travis-ci.org/akka/alpakka-kafka/jobs/527234960#L7401

Changes

  • TestKit now was KafkaTeskitSettings class that load settings from config
  • state waiting helpers are added to the ...javadsl.BaseKafkaTest
  • topic/groupid/transactionalid creation helpers are now usable from Java tests

2m added some commits May 3, 2019

@2m

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

Failure seems to be unrelated #788

@ennru

ennru approved these changes May 7, 2019

Copy link
Member

left a comment

Great to get proper support for Java users.
LGTM.

@ennru ennru added this to the 1.0.3 milestone May 7, 2019

@2m 2m merged commit c62941d into akka:master May 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
typesafe-cla-validator All users have signed the CLA
Details

@2m 2m deleted the 2m:wip-testkit-config-2m branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.