Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactional revoke on consumer thread #787

Merged

Conversation

Projects
None yet
2 participants
@szymonm
Copy link
Contributor

commented May 6, 2019

Purpose

As observed by @charlibot waiting for draining on the source actor thread is wrong (this happens because of using asyncCallback), because we never receive a message that the stream is drained. This fix is intended to fix that by forcing waiting for the draining on the consumer thread.
It also blocks the consumer from polling/releasing partitions, which was my intention from the beginning.

This is a quick fix. We should implement a proper fix on top of #761

References

References #785 #784 #761

@szymonm szymonm changed the title Szymon transactional revoke on consumer thread Transactional revoke on consumer thread May 6, 2019

@ennru ennru referenced this pull request May 7, 2019

Open

Alpakka team sprint plan 2019-05-06 #101

7 of 13 tasks complete
@2m

2m approved these changes May 7, 2019

Copy link
Member

left a comment

LGTM. Sorry I missed this in the review. Will merge it as soon as the other PR is merged.

@2m 2m force-pushed the szymonm:szymon-transactional-revoke-on-consumer-thread branch from 1c404b4 to 4989f97 May 8, 2019

@2m

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Rebased on top of master.

@2m

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Failure was #788

@2m 2m merged commit e3ff049 into akka:master May 8, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
typesafe-cla-validator All users have signed the CLA
Details

@2m 2m added this to the 1.0.3 milestone May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.