Google Cloud Storage: add access with new actors API #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrudolph
approved these changes
Mar 19, 2020
| @@ -15,3 +15,6 @@ ProblemFilters.exclude[MissingClassProblem]("main.scala.*") | |||
| ProblemFilters.exclude[IncompatibleSignatureProblem]("akka.stream.alpakka.googlecloud.storage.StorageObject.*") | |||
| ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.stream.alpakka.googlecloud.storage.StorageObject.withCustomerEncryption") | |||
| ProblemFilters.exclude[IncompatibleMethTypeProblem]("akka.stream.alpakka.googlecloud.storage.StorageObject.withOwner") | |||
|
|
|||
| # override of apply in extension with the concrete type instead of the generic type | |||
| ProblemFilters.exclude[IncompatibleResultTypeProblem]("akka.stream.alpakka.googlecloud.storage.GCStorageExt.apply") | |||
There was a problem hiding this comment.
Has this really changed? Maybe it's just lightbend/mima#433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement the
GCStorageExtextension with access methods forClassicActorSystemProviderwhich makes it usable without changed for the new actors API'sakka.actor.typed.ActorSystemwithout depending on that module.This can't be compiled against Akka 2.6 as
ExtensionIdin that version contains theapply(ClassicActorSystemProvider)method so it requires anoverridemodifier inGCStorageExt.See #2194, #2195, #2197, #2211, #2212