-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTP connector #4
Comments
After the first steps implementing the FTP connector I'd need your help / opinion in order to come up with a decent API for end users and also to clarify what would be the scope of the component in terms of offered capabilities. As I see it, we need to solve these four typical scenarios : browsing, retrieving, creating and deleting/moving, always following the reactive streams philosophy of course. The browsing part is what has been tackled so far, and it's in fact the default option via the FtpSource factory. This needs to be changed to accommodate the other features. Having said that, I can think of a couple of alternatives. First, having an unique façade and different factory-like methods. Something like this:
And the same for The other alternative could be to have different façades as I've had a look at how Camel is dealing with this and it's hard to draw conclusions as Camel's semantics is quite different from Akka Streams. For instance, Camel let you retrieve all files on some directory whereas I feel more natural in Akka Streams to generate a stream of file descriptors and then retrieve them one by one asynchronously. WDYT? |
I like the factory methods as you show in the example |
To track the in progress PR: #3
The text was updated successfully, but these errors were encountered: