New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML subtree flow #1099

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@takezoe
Contributor

takezoe commented Jul 8, 2018

Add XmlPasring.subtree which extracts elements match a certain path. This flow is similar to XmlPasring.subslice but pushes matched elements and their child nodes to the downstream as org.w3c.dom.Element instead of pure ParseEvent. It needs more memory, but it makes easier to handle iteration of sub tree of XML document.

If this pull request is acceptable, I will update the documentation as well.

@2m

This comment has been minimized.

Member

2m commented Jul 10, 2018

Thanks for the PR. I think the implementation looks good! It would be great if you could amend the docs. Then we can merge this!

@2m 2m added the p:xml label Jul 10, 2018

@takezoe

This comment has been minimized.

Contributor

takezoe commented Jul 10, 2018

I updated the document as well.

@2m

2m approved these changes Jul 11, 2018

Awesome. LGTM.

@2m 2m added this to the 0.21 milestone Jul 11, 2018

@2m 2m merged commit 6a70799 into akka:master Jul 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@takezoe takezoe deleted the takezoe:xml-subtree branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment