XML: add ability to provide a specific XMLOutputFactory #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
reviewed
Sep 24, 2019
|
@ennru I've added a scala and a java unit test. Tried to mock/spy the XMLOutputFactory w/mockito to verify that it's actually being used, but was unable to get that to work. I think b/c the implementation class is final and therefore cannot be mocked by mockito. I hope this suffices. |
ennru
changed the title
|
Great, thank you for proposing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
add ability to provide a specific XMLOutputFactory when instantiating an Xml Writer
References
References #1936
Changes
Background Context