Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchingSqlJournal now preserves Sender in PersistCallback #3779

Merged
merged 1 commit into from May 7, 2019

Conversation

@ismaelhamed
Copy link
Contributor

commented May 5, 2019

Currently, you have to capture Sender before calling Persist() when you use the BatchingSqlJournal, otherwise you end up with the wrong Sender in the PersistCallback.

@ismaelhamed

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

@Horusiath mind validating this, or suggesting an alternative solution?

@StephSanchez

This comment has been minimized.

Copy link

commented May 5, 2019

@Horusiath
Copy link
Contributor

left a comment

Only one little change. Beside that, everything looks good 👍

@@ -10,6 +10,10 @@
<NetStandardImplicitPackageVersion Condition=" '$(TargetFramework)' == 'netstandard1.6' ">1.6.1</NetStandardImplicitPackageVersion>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="System.ValueTuple" Version="4.5.0" />

This comment has been minimized.

Copy link
@Horusiath

Horusiath May 6, 2019

Contributor

While I'd like to move to value tuples, I think this is a change to be done directly on Akka core package ;)

This comment has been minimized.

Copy link
@ismaelhamed

ismaelhamed May 6, 2019

Author Contributor

Makes sense

@ismaelhamed ismaelhamed force-pushed the ismaelhamed:journal-fix-sender branch from c958bdd to c22ed96 May 6, 2019

@ismaelhamed ismaelhamed force-pushed the ismaelhamed:journal-fix-sender branch from c22ed96 to 0dd0c71 May 6, 2019

@ismaelhamed ismaelhamed changed the title [WIP] BatchingSqlJournal now preserves Sender in PersistCallback BatchingSqlJournal now preserves Sender in PersistCallback May 6, 2019

@ismaelhamed ismaelhamed marked this pull request as ready for review May 6, 2019

@Aaronontheweb

This comment has been minimized.

Copy link
Member

commented May 6, 2019

You good with the updates @Horusiath ?

@Horusiath Horusiath self-requested a review May 7, 2019

@Aaronontheweb Aaronontheweb merged commit bc5cc65 into akkadotnet:dev May 7, 2019

8 checks passed

continuous-integration/nuget-pack Finished TeamCity Build Akka.NET :: Akka.NET PR Build : Running
Details
continuous-integration/windows-build Finished TeamCity Build Akka.NET :: Akka.NET Windows Build : Running
Details
continuous-integration/windows-multinode-tests Finished TeamCity Build Akka.NET :: Akka.NET Windows MultiNodeTests : Tests passed: 98
Details
continuous-integration/windows-multinode-tests-netcore Finished TeamCity Build Akka.NET :: Akka.NET Windows MultiNode Tests (.NET Core) : Tests passed: 98
Details
continuous-integration/windows-perf-tests Finished TeamCity Build Akka.NET :: Akka.NET Windows Performance Tests : Tests passed: 131
Details
continuous-integration/windows-unit-tests Finished TeamCity Build Akka.NET :: Akka.NET Windows Unit Tests : Tests passed: 2507, ignored: 65, muted: 1
Details
continuous-integration/windows-unit-tests-netcore Finished TeamCity Build Akka.NET :: Akka.NET Windows Unit Tests (.NET Core) : Tests passed: 28
Details
linux-netcore/unit-tests Finished TeamCity Build Akka.NET :: Akka.NET Linux Unit Tests (.NET Core) : Tests passed: 28
Details

madmonkey added a commit to madmonkey/akka.net that referenced this pull request Jul 12, 2019

Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jul 21, 2019

Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jul 21, 2019

Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jul 26, 2019

@Aaronontheweb Aaronontheweb referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.