Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject Address into LogSource #3922

Draft
wants to merge 5 commits into
base: dev
from

Conversation

@Aaronontheweb
Copy link
Member

commented Sep 20, 2019

closes #3867

@Aaronontheweb

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2019

Still needs some unit test coverage before it's ready for primetime.

@Aaronontheweb

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2019

This broke some tests that were expecting LogSource to appear a specific way - that's to be expected. Will adjust the LogSource or the tests, depending on what looks more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.