Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script to be able to run Fake from a path that contains spaces #3924

Merged
merged 4 commits into from Sep 23, 2019

Conversation

@cptjazz
Copy link
Contributor

commented Sep 21, 2019

When using a checkout directory that contains spaces the PowerShell build script was unable to execute the Fake command. This PR fixes this issue by quoting the path to Fake in the Invoke-Expression statement.

cptjazz and others added 2 commits Sep 21, 2019
@@ -171,6 +171,6 @@ $Arguments = @{

# Start Fake
Write-Host "Running build script..."
Invoke-Expression "$FakeExePath `"build.fsx`" $ScriptArgs $Arguments"

Invoke-Expression "& `"$FakeExePath`" `"build.fsx`" $ScriptArgs $Arguments"

This comment has been minimized.

Copy link
@Aaronontheweb

Aaronontheweb Sep 21, 2019

Member

LGTM - I'll review the build system output and make sure that's germane.

@Aaronontheweb Aaronontheweb merged commit 8c02bcf into akkadotnet:dev Sep 23, 2019
8 checks passed
8 checks passed
PR Validation Build #2019.9.23.15 succeeded
Details
PR Validation (.NET Core Multi-Node Tests (Windows)) .NET Core Multi-Node Tests (Windows) succeeded
Details
PR Validation (.NET Core Unit Tests (Linux)) .NET Core Unit Tests (Linux) succeeded
Details
PR Validation (.NET Core Unit Tests (Windows)) .NET Core Unit Tests (Windows) succeeded
Details
PR Validation (.NET Framework Multi-Node Tests (Windows)) .NET Framework Multi-Node Tests (Windows) succeeded
Details
PR Validation (.NET Framework Unit Tests (Windows)) .NET Framework Unit Tests (Windows) succeeded
Details
PR Validation (NuGet Pack) NuGet Pack succeeded
Details
PR Validation (Windows Build) Windows Build succeeded
Details
@cptjazz cptjazz deleted the cptjazz:fix_fake_path branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.