Fix #4083 - Endpoint receive buffer stack overflow #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Dec 12, 2019
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Dec 20, 2019
Aaronontheweb
pushed a commit
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordering of the 2nd and 3rd parameters for C#'s
ConcurrentDictionary.TryUpdateare inverted from Scala'sMap.replace.public bool TryUpdate (TKey key, TValue newValue, TValue comparisonValue);docsvs
abstract def replace(k: A, oldvalue: B, newvalue: B): BooleandocsA quick review of the entire Akka.NET code base only shows a few usages of
TryUpdate. One in particular appears to have the old and new parameters backwards.(Scala implementation for reference)
https://github.com/akka/akka/blob/edaea382addc5831ca28beed504d879fcf01cd1a/akka-remote/src/main/scala/akka/remote/Endpoint.scala#L1111-L1114
This appears to be causing #4083