Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes performance issue with HighestSequenceNrSql query #5420

Conversation

lucavice
Copy link
Contributor

@lucavice lucavice commented Dec 8, 2021

Description of the PR purpose is provided in Issue #5419

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 8, 2021 15:09
@Aaronontheweb Aaronontheweb added perf akka-persistence-sql-common Akka.Persistence.Sql.Common labels Dec 8, 2021
@Aaronontheweb Aaronontheweb merged commit c1b0924 into akkadotnet:dev Dec 8, 2021
@lucavice lucavice deleted the 5419-performance_fix_to_highest_sequence_nr_query branch December 8, 2021 15:43
@Aaronontheweb Aaronontheweb mentioned this pull request Dec 13, 2021
@lucavice
Copy link
Contributor Author

@Aaronontheweb we finally rolled out the updated version to our production environment, and I just wanted to share how big of a difference this made to our DTU usage in Azure SQL during Akka bootup:

Before (capped at 100% for almost 10 minutes):
before

After (peaked at 8% for less than a minute):
after (2)

@Aaronontheweb
Copy link
Member

@lucavice what a tremendous improvement! Thank you for your contribution!

@Aaronontheweb
Copy link
Member

Adding an issue to help us screen for this in the future: #5503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-persistence-sql-common Akka.Persistence.Sql.Common perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants