Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap all exception thrown while trying to dispatch messages in Akka.Remote.EndpointReader #5971

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented May 27, 2022

Changes

Trap all exceptions when we try to dispatch/deserialize an InboundPayload in Akka.Remote.EndpointReader receiver.

catch (Exception e)
{
throw;
LogTransientSerializationError(ackAndMessage.MessageOption, e);
Copy link
Member

@Aaronontheweb Aaronontheweb May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to just make this a catch all because libraries like Newtonsoft.Json don't throw either of the handled cases above. If you have a serialization problem, it's your fault - we'll log it and not let it blow up the connection. On the user to fix it.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 27, 2022
@Aaronontheweb Aaronontheweb disabled auto-merge May 27, 2022
@Aaronontheweb Aaronontheweb merged commit 0e7cd06 into akkadotnet:v1.4 May 27, 2022
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants