Fixing up cluster rejoin behavior #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (handle.IsFaulted) | ||
| { | ||
| var inner = handle.Exception.Flatten().InnerException; | ||
| return (object)new Status.Failure(new InvalidAssociationException("Association failure", inner)); |
There was a problem hiding this comment.
Not sure if this is the right status failure
|
The ClusterDomainEventPublisherSpec is still failing all tests for this build. |
|
@Aaronontheweb After this build i'll rebase and squash |
|
|
||
| if (alreadyMember) _log.Info("Existing member [{0}] is trying to join, ignoring", node); | ||
| else if (isUnreachable) _log.Info("Unreachable member [{0}] is trying to join, ignoring", node); | ||
| if (localMember != null && localMember.UniqueAddress == node) |
There was a problem hiding this comment.
were these just areas where we weren't totally up to date with the JVM version?
|
#918 linking issue |
| _log.Info("New incarnation of existing member [{0}] is trying to join. " + | ||
| "Existing will be removed from the cluster and then new member will be allowed to join.", node); | ||
| if (localMember.Status != MemberStatus.Down && localMember.Status != MemberStatus.Leaving && localMember.Status != MemberStatus.Exiting) | ||
| Downing(localMember.Address); |
There was a problem hiding this comment.
so is this where the magic happens for downing the unreachable node going forward? The "big fix" as it were?
There was a problem hiding this comment.
This is the big fix for #918 . This allows the node to rejoin
There was a problem hiding this comment.
cool - that's what I thought. Awesome - looks simple enough and explains what wasn't working well before.
Fixed rejoining node Fixed ClusterDomainEventPublisher spec
Aaronontheweb
added a commit
that referenced
this pull request
May 11, 2015
…vior Fixing up cluster rejoin behavior
This was referenced Jun 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed rejoining node