Cookie settings aren't flexible enough #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoenig
pushed a commit
that referenced
this pull request
Mar 18, 2013
Cookie settings aren't flexible enough
|
Thanks a lot. Will be in the next release. Would you mind to extend the README as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that the locale cookie should be stored with the default path and domain is a little bit unwieldy, and prevents localization from working across subdomains, for example.
This pull request allows cookie options to be provided externally, overriding the current setting. The default is to use httpOnly cookies, but this can be overridden as well, which should resolve the issue knarz reported six months ago.