Browse files

sunos-os.c: Do not lose on mmap failure

Brings this platform in line with other POSIX backends.  It is desirable
that we do not `lose' just because too many threads have been created,
for reasons of user-friendliness -- and also because individual
ill-behaved tests should not cause the entire run-tests process to fail.
  • Loading branch information...
1 parent 89d479d commit 2b67d29226463dff2ee971553c6a1eaf3f1e09d0 @lichtblau lichtblau committed Sep 18, 2012
Showing with 7 additions and 1 deletion.
  1. +7 −1 src/runtime/sunos-os.c
@@ -51,7 +51,13 @@ os_vm_address_t os_validate(os_vm_address_t addr, os_vm_size_t len)
if (addr == MAP_FAILED) {
- lose ("Error in mmap(..)\n");
+ /* While it is generally hard to recover from out-of-memory
+ * situations, we require callers to decide on the right course
+ * of action here. Consider thread creation: Failure to mmap
+ * here is common if users have started too many threads, and
+ * often we can recover from that and treat it as an ordinary
+ * error. */
+ return 0;
return addr;

0 comments on commit 2b67d29

Please sign in to comment.