Skip to content

Commit

Permalink
1.0.27.24: robustify DEFPACKAGE form pretty-printing
Browse files Browse the repository at this point in the history
 * Thanks to Sidney Markowitz.

 * A few missing NEWS entries.
  • Loading branch information
nikodemus committed Apr 23, 2009
1 parent 4c4e357 commit e303f38
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 2 deletions.
9 changes: 9 additions & 0 deletions NEWS
@@ -1,5 +1,14 @@
;;;; -*- coding: utf-8; fill-column: 78 -*-
changes in sbcl-1.0.28 relative to 1.0.27:
* bug fix: pretty printing malformed DEFPACKAGE forms (thanks to Sidney
Markowitz)
* bug fix: running regressions tests in shells without OSTYPE set now works.
(reported by Harald Hanche-Olsen)
* bug fix: more robust static space exhaustion signalling from
MAKE-STATIC-VECTOR (thanks to Daniel Lowe)
* bug fix: (SETF DOCUMENTATION) for anonymous function now throws the
docstring away instead of storing it under names such as (LAMBDA (X)).
(reported by Leslie Polzer)
* bug fix: timers could go off in the wrong order, be delayed indefinitely
(thanks to Ole Arndt for the patch)
* bug fix: RESTART-FRAME and RETURN-FROM-FRAME stack corruption
Expand Down
2 changes: 1 addition & 1 deletion src/code/pprint.lisp
Expand Up @@ -1241,7 +1241,7 @@ line break."
(defun pprint-defpackage (stream list &rest noise)
(declare (ignore noise))
(funcall (formatter
"~:<~W~^ ~3I~:_~W~^~1I~@{~:@_~:<~W~^ ~:I~@_~@{~W~^ ~_~}~:>~}~:>")
"~:<~W~^ ~3I~:_~W~^~1I~@{~:@_~:<~^~W~^ ~:I~@_~@{~W~^ ~_~}~:>~}~:>")
stream
list))

Expand Down
6 changes: 6 additions & 0 deletions tests/pprint.impure.lisp
Expand Up @@ -200,5 +200,11 @@
(assert (string= "#1=(#2=(#2# . #3=(#1# . #3#)))"
(with-output-to-string (s)
(write '#1=(#2=(#2# . #3=(#1# . #3#))) :stream s)))))

;;; Printing malformed defpackage forms without errors.
(with-test (:name :pprint-defpackage)
(with-open-stream (null (make-broadcast-stream))
(pprint '(defpackage :foo nil))
(pprint '(defpackage :foo 42))))

;;; success
2 changes: 1 addition & 1 deletion version.lisp-expr
Expand Up @@ -17,4 +17,4 @@
;;; checkins which aren't released. (And occasionally for internal
;;; versions, especially for internal versions off the main CVS
;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".)
"1.0.27.23"
"1.0.27.24"

0 comments on commit e303f38

Please sign in to comment.