Skip to content

Adam Krebs akre54

Organizations

FarmTab
akre54 deleted branch unique-array at akre54/chancejs
akre54 commented on pull request jashkenas/coffeescript#3537
Adam Krebs

:thumbsdown: CoffeeScript targets ES3, and Object.defineProperty can't be relied upon to exist in an older environment.

akre54 commented on pull request jashkenas/coffeescript#3537
Adam Krebs

More cleanly written as: get: -> @__prop set: (@__prop) ->

akre54 commented on pull request jashkenas/underscore#1737
akre54 commented on issue jashkenas/underscore#1736
Adam Krebs

But Resig's templates didn't support settings :) (wayback machine for anyone interested)

akre54 commented on issue jashkenas/underscore#1736
Adam Krebs

Yeah I agree with this. _.template should always return a function.

akre54 commented on issue paulmillr/exoskeleton#76
Adam Krebs

If you need IE8 support use Backbone. If you don't, use Exoskeleton. They're two projects with competing goals. The addition of Underscore to your …

akre54 commented on issue chaplinjs/chaplin#821
Adam Krebs

Yeah. Chaplin works around this by doing the event rebinding for you, but this all seems very hacky and slow without much clear benefit. Backbone V…

akre54 commented on issue paulmillr/exoskeleton#76
Adam Krebs

Yeah we could probably pull out most of those hasOwnProp checks (I'm not entirely convinced in that article though) since what we're mostly interes…

akre54 commented on issue paulmillr/exoskeleton#76
akre54 commented on issue chaplinjs/chaplin#821
Adam Krebs

Mostly in binding / unbinding events, since the noWrap logic comes after you render (which in normal circumstances should be idempotent on your eve…

akre54 commented on issue chaplinjs/chaplin#821
Adam Krebs

I'd recommend avoiding noWrap. It's an unfortunate reality of Backbone that every view needs to own an element, but noWrap is an ugly hack that cau…

akre54 commented on issue jashkenas/underscore#1715
Adam Krebs

Something like this? diff --git a/underscore.js b/underscore.js index 523723d..d9fb5a8 100644 --- a/underscore.js +++ b/underscore.js @@ -1072,7 +1…

Adam Krebs
Inconsistent results when passing empty jQuery object to _.isEmpty
akre54 commented on issue jashkenas/underscore#1727
Adam Krebs

Btw it's not onerous for devs to implement _.each in terms of a for-loop either :package: Sure, but much less aesthetically pleasing. Though slightly nic…

akre54 commented on issue jashkenas/underscore#1597
Adam Krebs

Can you just mixin yourself? If the din becomes loud enough, might make sense to add back into core.

akre54 commented on issue jashkenas/underscore#1621
Adam Krebs

What's the aversion to opening pulls yourself? I follow the lodash repo but I really have no interest in constantly comparing implementations.

akre54 commented on issue jashkenas/underscore#1621
Adam Krebs

So is the || false fix worth adding? Want to open a pull if so?

akre54 commented on pull request jashkenas/underscore#1712
Adam Krebs

Got a perf for this? I'm imagining the wins are pretty big, but it'd be good to see for sure.

Adam Krebs
Inconsistent results when passing empty jQuery object to _.isEmpty
akre54 commented on issue jashkenas/underscore#1715
Adam Krebs

I don't know about duck-typing the splice method. It probably works but it seems... hackish. It's surprising to me that jQuery doesn't already have…

Adam Krebs
Zip cannot be chained
akre54 commented on issue jashkenas/underscore#1597
Adam Krebs

Unless we massively rewrite the way chaining works (and I've tried.... it gets ugly fast), there's really not much we can do about it. Just use the…

akre54 closed pull request jashkenas/underscore#1611
Adam Krebs
Patch cross domain object check
akre54 commented on issue jashkenas/underscore#1621
Adam Krebs

Is this still needed?

Adam Krebs
Proposal: _.argumentCall
Adam Krebs
Proposal "hello {0}".format('world')
Adam Krebs
Allow placeholder to be customized
Adam Krebs
Add _.attempt
akre54 commented on issue jashkenas/underscore#1727
Adam Krebs

Agreed with Michael. If you're truly worried about the performance of your code, it's not onerous to throw the try-catch in a separate function. In…

Something went wrong with that request. Please try again.