-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): display freight contents in freight details page #1979
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
=======================================
Coverage 46.23% 46.23%
=======================================
Files 235 235
Lines 16029 16029
=======================================
Hits 7411 7411
Misses 8256 8256
Partials 362 362 ☔ View full report in Codecov by Sentry. |
This looks good to me, except that I am wondering if we should use the term 'artifacts' instead of 'contents'. I think it would help get the concept of Freight better across, which is (at least as I understand it) "a collection of artifacts". |
Double-checking my suggestion, it would also better align with how we describe Freight ourselves in the documentation:
|
Signed-off-by: Remington Breeze <remington@breeze.software>
@hiddeco thanks for the suggestion! changed ✅ |
Also adds links to Freight Details in Promotions table, and a tooltip showing the Freight alias (related to #1822):