Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): display freight contents in freight details page #1979

Merged
merged 2 commits into from
May 13, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented May 9, 2024

Screenshot 2024-05-08 at 17 28 16

Also adds links to Freight Details in Promotions table, and a tooltip showing the Freight alias (related to #1822):
Screenshot 2024-05-08 at 17 28 05

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner May 9, 2024 00:30
Copy link

netlify bot commented May 9, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 419d88d
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/663e91a57081a4000896f798
😎 Deploy Preview https://deploy-preview-1979.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.23%. Comparing base (677fd5e) to head (419d88d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1979   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files         235      235           
  Lines       16029    16029           
=======================================
  Hits         7411     7411           
  Misses       8256     8256           
  Partials      362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco
Copy link
Contributor

hiddeco commented May 9, 2024

This looks good to me, except that I am wondering if we should use the term 'artifacts' instead of 'contents'. I think it would help get the concept of Freight better across, which is (at least as I understand it) "a collection of artifacts".

@hiddeco
Copy link
Contributor

hiddeco commented May 9, 2024

Double-checking my suggestion, it would also better align with how we describe Freight ourselves in the documentation:

Freight is an important Kargo concept. A single "piece of freight" is a set of references to one or more versioned artifacts, [...]
https://kargo.akuity.io/how-to-guides/working-with-freight

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
Copy link
Contributor Author

rbreeze commented May 10, 2024

@hiddeco thanks for the suggestion! changed ✅

@rbreeze rbreeze enabled auto-merge May 10, 2024 21:48
@rbreeze rbreeze added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit cef0c98 May 13, 2024
17 checks passed
@rbreeze rbreeze deleted the freight-details branch May 13, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants