Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to watch Argo CD Applications only in Argo CD's namespace #448

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

krancour
Copy link
Member

@krancour krancour commented Jun 27, 2023

This option makes it possible to dial back permissions a bit farther when needed.

WIP because I am still cleaning up the charts a bit.

#449 should also be merged first.

cc @gdsoumya

@krancour krancour added this to the v0.1.0 milestone Jun 27, 2023
@krancour krancour self-assigned this Jun 27, 2023
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit d5b1bf3
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/649c4759ded7fc0008d90352

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #448 (d5b1bf3) into main (cf8e833) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #448   +/-   ##
=======================================
  Coverage   52.22%   52.22%           
=======================================
  Files          46       46           
  Lines        4366     4366           
=======================================
  Hits         2280     2280           
  Misses       1993     1993           
  Partials       93       93           

Copy link
Contributor

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdsoumya gdsoumya marked this pull request as ready for review June 28, 2023 03:40
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/apps-in-one-ns branch 2 times, most recently from b625823 to 5e4a4f2 Compare June 28, 2023 14:31
@krancour krancour marked this pull request as draft June 28, 2023 14:37
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour marked this pull request as ready for review June 28, 2023 14:44
@gdsoumya gdsoumya merged commit 15f274a into akuity:main Jun 28, 2023
13 checks passed
@krancour krancour deleted the krancour/apps-in-one-ns branch June 29, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants