New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchers not added for new issue #1

Open
evfool opened this Issue Aug 22, 2014 · 10 comments

Comments

Projects
None yet
2 participants
@evfool

evfool commented Aug 22, 2014

Testing on Redmine 2.5.2, with an issue category having a group as the default assignee

How to reproduce:

  • create a new issue with the issue category created above, but don't set an assignee

Expected:

  • assignee is set to the default assignee of the issue category, and the watchers are added accordingly

What happens instead:

  • the assignee is set to the default assignee of the issue category, but no watchers are added.

Workaround:
on reassigning to the same group the watchers are added, or one could set both the category and the assignee right from the start, but issue category default assignee was added to avoid that

@akuznecov

This comment has been minimized.

Owner

akuznecov commented Aug 22, 2014

@evfool just realized that I completely forgot about category functional :( thanks for pointing me on it!
could you test commit above?

@evfool

This comment has been minimized.

evfool commented Aug 23, 2014

Unfortunately it still doesn't work, setting a category with a group as default assignee, no watchers are added to a new issue, but editing it and saving it (without any changes) adds the watchers from the group.

@evfool

This comment has been minimized.

evfool commented Aug 31, 2014

Could I do anything to further help you in fixing this? I have tried debugging locally, but I'm not very familiar with Ruby, so I couldn't fix it in one day or so.

@akuznecov

This comment has been minimized.

Owner

akuznecov commented Sep 2, 2014

@evfool just installed clean 2.5.2 and reproduced your problem - will try to find a way to fix this bug

akuznecov added a commit that referenced this issue Sep 2, 2014

@akuznecov

This comment has been minimized.

Owner

akuznecov commented Sep 2, 2014

@evfool could you test with latest commit? It works well for me on 2.3.2 and 2.5.2 for normal group assign and issue category default assign

@evfool

This comment has been minimized.

evfool commented Sep 2, 2014

Unfortunately it still doesn't work (in the meantime I have reverted to 2.5.1.stable, that's what's available on FreeBSD by default, but if it works for you on 2.3.2 and 2.5.2, this shouldn't be a problem), maybe it's a setting I am missing:

  • in general Settings, I set issues assignable to groups checkbox
  • I create a group with two of my users, add some roles, and add it to the project
  • add the group as the default assignee for a category
  • create a new issue with only the required fields set (title, tracker, status, priority) and additionally the category I have set the group as default assignee, click create
    The result with the latest master version is still the same, assignee is set based on the category's default, but watchers are not added (no watchers visible on the sidebar).
@akuznecov

This comment has been minimized.

Owner

akuznecov commented Sep 2, 2014

@evfool, just to ensure, have you marked newly created group as Active on Admin > Plugins > Redmine Auto Watchers From Groups plugin > Configure (http://your.host.name/settings/plugin/redmine_auto_watchers_from_groups) ?

@evfool

This comment has been minimized.

evfool commented Sep 2, 2014

@akuznecov You were right, I forgot to set it this time, but regardless, tried adding the group, applying, and creating a new issue, but it still happens, no watchers added.

@akuznecov

This comment has been minimized.

Owner

akuznecov commented Sep 8, 2014

@evfool my apologies about delay, could specify your ruby version?
just installed clean 2.5.1 - and no issue :(

@evfool

This comment has been minimized.

evfool commented Sep 8, 2014

I doubt that the ruby version is the one to blame. It must be a plugin incompatibility somewhere.
I have just tried on a fresh (and clean) redmine install, and the plugin works flawlessly.
On the other hand on my production instance it still doesn't work, with the following plugins installed:

  • redmine_bootstrap_kit
  • redmine_category_tree
  • redmine_custom_css
  • redmine_custom_js
  • redmine_custom_workflows
  • redmine_default_version
  • redmine_issue_status_colors
  • redmine_jenkins
  • redmine_landing_page
  • redmine_local_avatars
  • redmine_menu_links
  • redmine_open_search
  • redmine_revision_diff
  • redmine_subtasks_inherited_fields
  • redmine_tags
  • redmine_theme_changer
  • redmine_wiki_lists
  • status_button
  • timelog_timer
  • wiking

Most of these have nothing to do with the issue aftersave, so are not likely to interfere with your plugin, but e.g. default_version and custom_workflows also register their after_save. It seems that it's not your plugin that has the problem, but the setup has an incompatibility. I will try to find exactly which one is causing the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment