feat(readme): update readMe, update replace method #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions, update replace method, set icon animation as more priority than common replace.
nnixaa
requested changes
Nov 12, 2018
README.md
Outdated
| <i data-eva="github" data-eva-animation="zoom"></i> | ||
| ``` | ||
|
|
||
| - By default animation works by hover and has infinity `false`, if you want change this behavior add `data-eva-hover="true | false"` and `data-eva-infinite="true | false"` |
There was a problem hiding this comment.
this sentence is quite hard to understand, try to rephrase
README.md
Outdated
| ``` | ||
| > **Note:** The animation will be applied to all replaced elements. | ||
|
|
||
| - Add class `eva-parent-hover` to parent container if you want that the animation works by hover on the parent element. |
There was a problem hiding this comment.
Suggested change
| - Add class `eva-parent-hover` to parent container if you want that the animation works by hover on the parent element. | |
| - Add `eva-parent-hover` class to the parent container in a case you want to activate the animation hovering on the parent element. |
nnixaa
requested changes
Nov 12, 2018
README.md
Outdated
| ``` | ||
|
|
||
| - Additional animation attributes: | ||
| * `data-eva-hover`: Makes an animation available by hover. Default value is `true`. Available true or false. |
There was a problem hiding this comment.
Suggested change
| * `data-eva-hover`: Makes an animation available by hover. Default value is `true`. Available true or false. | |
| * `data-eva-hover`: Makes the animation available on hover. Default value is `true`. Available `true` or `false`. |
README.md
Outdated
|
|
||
| - Additional animation attributes: | ||
| * `data-eva-hover`: Makes an animation available by hover. Default value is `true`. Available true or false. | ||
| * `data-eva-infinite`: Makes animation as infinity. Default value is `false`. Available true or false. |
There was a problem hiding this comment.
Suggested change
| * `data-eva-infinite`: Makes animation as infinity. Default value is `false`. Available true or false. | |
| * `data-eva-infinite`: Makes the animation infinite. Default value is `false`. Available `true` or `false`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.