New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lint): explorer app #132
Conversation
example/screens/AvatarScreen.js
Outdated
<View style={[UtilStyles.section, UtilStyles.bordered]}> | ||
<RkText rkType='header'>Base avatar</RkText> | ||
<View style={UtilStyles.columnContainer}> | ||
<Avatar source={require('../img/avatars/image3.png')} name='Elena Zhukova' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep abstract names
example/screens/ButtonScreen.js
Outdated
<RkText>Button</RkText> | ||
<RkText rkType='danger'>{"</RkButton>"}</RkText> | ||
</View> | ||
render = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to define render
method as property?
We never call it directly.
<RkChoice | ||
style={{ backgroundColor: 'transparent', borderWidth: 0 }} | ||
renderContentFunction={this.renderCustomChoiceContent} | ||
selected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a chance to add a rule which will stand that value is mandatory for all attributes?
example/screens/ComponentsScreen.js
Outdated
renderSeparator={this.renderSeparator} | ||
automaticallyAdjustContentInsets | ||
keyboardDismissMode="on-drag" | ||
keyboardShouldPersistTaps='always' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about quotes here?
example/screens/SettingsScreen.js
Outdated
style={UtilStyles.container} | ||
automaticallyAdjustContentInsets={true}> | ||
onChoiceGroupValueChange = (index) => { | ||
// const { params } = this.props.navigation.state; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comment
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fix of eslint warnings in explorer app