From 4ae3873959c95da39e21d875ec847d8b0653aa18 Mon Sep 17 00:00:00 2001 From: Vladimir Lugovsky Date: Thu, 30 Apr 2015 16:56:35 +0300 Subject: [PATCH] fix($compile): change directive name validation error entry As angular team suggested, it's better use 'baddir' error entry for whitespace validation. Closes #11397 --- src/ng/compile.js | 2 +- test/ng/compileSpec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ng/compile.js b/src/ng/compile.js index eb52fa446fce..140e5b61559c 100644 --- a/src/ng/compile.js +++ b/src/ng/compile.js @@ -803,7 +803,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { throw $compileMinErr('baddir', "Directive name '{0}' is invalid. The first character must be a lowercase letter", name); } if (name !== name.trim()) { - throw $compileMinErr('baddirwspc', + throw $compileMinErr('baddir', "Directive name '{0}' is invalid. The name should not contain leading or trailing whitespaces", name); } diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js index dbb0f82915a9..27e5dcb3c8a0 100755 --- a/test/ng/compileSpec.js +++ b/test/ng/compileSpec.js @@ -217,7 +217,7 @@ describe('$compile', function() { expect(function() { directive(name, function() { }); }).toThrowMinErr( - '$compile','baddirwspc', 'Directive name \'' + name + '\' is invalid. ' + + '$compile','baddir', 'Directive name \'' + name + '\' is invalid. ' + "The name should not contain leading or trailing whitespaces"); } assertLeadingOrTrailingWhitespaceInDirectiveName(' leadingWhitespaceDirectiveName');