Issue/2639 form export full (connect #2639) #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update copyright of files and check codacy errors |
| private int createFullHeader(HSSFSheet sheet, int startRow, HSSFCellStyle style) { | ||
| int r = startRow, c = 0; | ||
| HSSFRow row = sheet.createRow(r++); | ||
| //createCell(row, c++, "Form version", style); |
There was a problem hiding this comment.
Shall we maybe remove the commented out code?
| } | ||
|
|
||
| /** | ||
| * creates a cell in the row passed in and sets the style and value (if |
There was a problem hiding this comment.
I think, the comment should explain more what it does with width
| createCellBlock(row, c += 3, "Numbers", style, 4); // 4 wide | ||
| createCellBlock(row, c += 4, "Options", style, 3); // 3 wide | ||
| createCellBlock(row, c += 3, "Geolocation", style, 2); // 2 wide | ||
| createCell( row, c += 2, "Cascade", style); |
There was a problem hiding this comment.
isn't there too much spacing here after '('
There was a problem hiding this comment.
I wanted it to align vertically so you can see the pattern of it.
| createCellBlock(row, c += 3, "Geolocation", style, 2); // 2 wide | ||
| createCell( row, c += 2, "Cascade", style); | ||
| createCellBlock(row, c += 1, "Geographic area", style, 3); // 3 wide | ||
| createCell( row, c += 3, "Caddisfly", style); |
There was a problem hiding this comment.
same comment as above
valllllll2000
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR (what is the issue or what needed to be done)
Form export was just meant for a paper form
The solution
Add another sheet that shows details for all groups and questions of entire form as a table.
Screenshots (if appropriate)
Checklist