New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several changes #2
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detail: inconsistent use of tabs and spaces in indentation (__init__.py, line 55) Error: Error in python: TabError
…et, changed the clone uri from Bitbucket to GitHub.
…rected some misused tabs and tested it against several PostgreSQL versions.
…se. Therefore I added the license to the repo.
Hi Janine,
I'm back from Holliday's and happy to see that someone is interested into
this fdw.
I saw recently that it have problems and planned to search why when I'll
had time as I don't use it myself other than for experimentations.
I have a lot of things to handle after holliday but I'll be happy to put my
hands into it after some days.
Thank you
Alain
Le jeu. 4 août 2022 à 16:21, Stefanie Janine Stölting <
***@***.***> a écrit :
… Hi,
I changed some stuff for example I switched over to multicorn2 as
multucorn itself seems not to be supported anymore.
For example it didn't work with PostgreSQL 14.
In addition I extended the documentation.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- bc7bc6a
<bc7bc6a>
Solved an error on "CREATE SERVER"
- fda58cd
<fda58cd>
Added installation desccription for Debian/Ubuntu systems using apt-get,
changed the clone uri from Bitbucket to GitHub.
- e6e1ed9
<e6e1ed9>
Corrected a missing tab.
- 32c8386
<32c8386>
Changed the documentation to use multicorn2 instead of multicorn. Corrected
some misused tabs and tested it against several PostgreSQL versions.
File Changes
(3 files <https://github.com/al1radix/sparql_fdw/pull/2/files>)
- *M* README.md
<https://github.com/al1radix/sparql_fdw/pull/2/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(79)
- *M* setup.py
<https://github.com/al1radix/sparql_fdw/pull/2/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7>
(6)
- *M* sparqlfdw/__init__.py
<https://github.com/al1radix/sparql_fdw/pull/2/files#diff-88655e394b8c38353cc72c0190d769d04b6be2b74c48d49f6388b8685da04fc7>
(25)
Patch Links:
- https://github.com/al1radix/sparql_fdw/pull/2.patch
- https://github.com/al1radix/sparql_fdw/pull/2.diff
—
Reply to this email directly, view it on GitHub
<#2>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADIGHVORBWWTHPO46YCH2WDVXPGX5ANCNFSM55SX2EUA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi Alain, Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I changed some stuff for example I switched over to multicorn2 as multucorn itself seems not to be supported anymore.
For example it didn't work with PostgreSQL 14.
In addition I extended the documentation.