Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis clang build #110

Merged
merged 3 commits into from May 24, 2018
Merged

Fix travis clang build #110

merged 3 commits into from May 24, 2018

Conversation

Scheirle
Copy link
Member

This reverts commit d0f092c.

Let's see if clang builds or not.

@florianjacob
Copy link
Member

In file included from /home/travis/build/alacarte-maps/alacarte/src/server/eval/function_operation_node.cpp:27:
In file included from /home/travis/build/alacarte-maps/alacarte/include/server/parser/color_grammar.hpp:25:
/usr/include/boost/spirit/home/qi/string/tst_map.hpp:74:38: error: invalid use of incomplete type 'boost::spirit::qi::tst_pass_through'
            return find(first, last, tst_pass_through());
                                     ^~~~~~~~~~~~~~~~~~
/usr/include/boost/spirit/home/qi/string/tst_map.hpp:20:12: note: forward declaration of 'boost::spirit::qi::tst_pass_through'
    struct tst_pass_through; // declared in tst.hpp
           ^
[  6%] Building CXX object CMakeFiles/alacarte-obj.dir/src/utils/applications.cpp.o
1 error generated.
make[2]: *** [CMakeFiles/server-obj.dir/src/server/eval/function_operation_node.cpp.o] Error 1
make[1]: *** [CMakeFiles/server-obj.dir/all] Error 2

strange stuff… how can this work in gcc but not in clang?

@Scheirle
Copy link
Member Author

Bug in boost: https://svn.boost.org/trac10/ticket/9468

GCC is not as strict as clang and is therefore able to compile it, because we include
boost/spirit/home/qi/string/tst.hpp via mapcss_def.hpp and therefore the type is fully know before we use it.

@florianjacob
Copy link
Member

Now look at who reported and provided a fix for that bug years ago, our good alacarte friend @AMDmi3 😄

So it seems like the boost version we use on travis is still too old to contain that fix?

@Scheirle Scheirle changed the title Revert "[travis] disable clang" Fix travis clang build May 23, 2018
@Scheirle Scheirle merged commit a9bc098 into master May 24, 2018
@Scheirle Scheirle deleted the pr_103_fix2 branch May 24, 2018 16:09
@florianjacob
Copy link
Member

@Scheirle comparably nice workaround! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants