Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scrollback #124

Closed
theduke opened this issue Jan 7, 2017 · 69 comments
Closed

Implement scrollback #124

theduke opened this issue Jan 7, 2017 · 69 comments

Comments

@theduke
Copy link

@theduke theduke commented Jan 7, 2017

Since you got so much pushback on the scrollback support, and mentioned possibly implementing it,
I'm opening this as a tracking issue.

(ps: I also really want scrollback w/o tmux).

@dbrgn
Copy link

@dbrgn dbrgn commented Jan 7, 2017

I would also love to see scrolling. I fully share your point of view regarding tabs and tiling (I use a tiling window manager, so no need for that). But scrollback is really something basic to me that shouldn't belong in a separate program.

But of course, the classification into "basic" and "not basic" is quite subjective :)

@jwilm
Copy link
Collaborator

@jwilm jwilm commented Jan 7, 2017

I'm not committing to adding this just yet, but I would like to mention something for those against this decision. If Alacritty were to add scrolling support, it would be as an opt-in feature. When not opting in, the code paths would be completely compiled out, and performance would not suffer.

@albinekb
Copy link

@albinekb albinekb commented Jan 8, 2017

@jwilm how do you use your terminal without scrollback? 🤔 (curious)

@aeosynth
Copy link

@aeosynth aeosynth commented Jan 8, 2017

https://github.com/jwilm/alacritty#about

Instead, it is expected that users of Alacritty make use of a terminal multiplexer such as tmux.

@p-e-w
Copy link

@p-e-w p-e-w commented Jan 15, 2017

It is worth noting that while Alacritty is the fastest terminal emulator on systems without the Mesa bug, "Alacritty + tmux" is actually slower than some other terminals which provide scrollback without tmux.

Therefore, if you are only using tmux to get scrollback and are not interested in its other features, Alacritty is not your fastest option anymore.

@jwilm jwilm mentioned this issue Feb 7, 2017
@kurnevsky
Copy link
Contributor

@kurnevsky kurnevsky commented Feb 9, 2017

Besides scrollback tmux handles window resizing with lines wrapping. I've tried many lightweight terminals - each one was buggy with this. So it was the main reason why I started using tmux.

@dbrgn
Copy link

@dbrgn dbrgn commented Feb 10, 2017

Alacritty could be the first one that gets it right :)

@JelteF
Copy link

@JelteF JelteF commented Mar 23, 2017

@kurnevsky @dbrgn The 0.8.x releases of xfce4-terminal (released during the last 6 months) have been great at wrapping lines for me. XFCE is also known to be quite minimal and not requiring a lot of dependencies. If you're still looking for a good minimal terminal with scrollback and line wrap I suggest you try it.

@neon64
Copy link

@neon64 neon64 commented Apr 10, 2017

Perhaps I have a rather niche use case, but I find scrollback an extremely important feature. Instead of using tmux like it suggests in the README, I use i3 to handle tabs and other window layout needs. However of course it won't handle scrollback for me.

PS: I know how annoying it can be for random users to whine about lacking features.. So I thought I could offer to try and implement this in my spare time. I have about a year of experience using Rust 'as a hobbyist' on weekends. The problem is, I have no experience with terminal emulators and it might take a while to get my head around this codebase.

@jwilm
Copy link
Collaborator

@jwilm jwilm commented Apr 10, 2017

Thanks for the feedback @neon64!

Perhaps I have a rather niche use case, but I find scrollback an extremely important feature. Instead of using tmux like it suggests in the README, I use i3 to handle tabs and other window layout needs. However of course it won't handle scrollback for me.

This was actually a rather common sentiment in response to the initial Alacritty announcement. I've actually switched to using i3 and have relegated my own use of tmux to remote machines. As such, I'm now in a similar boat wishing for scrollback 😆.

PS: I know how annoying it can be for random users to whine about lacking features..

Quite the contrary, actually! It's incredibly helpful to hear what users want. This is part of how features are prioritized.

So I thought I could offer to try and implement this in my spare time. I have about a year of experience using Rust 'as a hobbyist' on weekends. The problem is, I have no experience with terminal emulators and it might take a while to get my head around this codebase.

I would be more than happy to help acquaint you with the codebase. I haven't (yet) put much thought into how scrollback should be implemented, but I do have a few initial thoughts:

  • [Requirement] Must be able to opt-in/out via compile time feature flag. The opt-out version should be as performant as current versions which don't support scrollback.
  • Probably want to store list of Vec<Row<Cell>> as the scrollback buffer.
  • Chief challenge is identifying efficient way to move Rows between the grid and the scrollback buffer.
  • Maybe the Grid should become a view into the scroll/line buffer?

@ghost
Copy link

@ghost ghost commented Apr 10, 2017

Quite the contrary, actually! It's incredibly helpful to hear what users want. This is part of how features are prioritized

a scheduled pre-build build, distributed by homebrew cask would cool 👍

@jwilm
Copy link
Collaborator

@jwilm jwilm commented Apr 11, 2017

Btw @neon64, if you want to ask questions about the code, I'd be more than happy to talk about it in our IRC channel.

@neon64
Copy link

@neon64 neon64 commented Apr 12, 2017

Thanks for the assistance @jwilm - I'll have a look myself over the next few days and see if I can do anything...

@denten
Copy link

@denten denten commented May 14, 2017

A few specific use cases where tmux for scrolling can result in a pretty unstable experience:

  1. Adding tmux to bashrc has the potential to lock user out of the system.
  2. Abandoned sessions quickly pile up due to window kill and reuse. It is not obvious how to solve this in a way that would keep the tmux session log tidy.

@algesten
Copy link
Contributor

@algesten algesten commented May 14, 2017

@denten I have no such problems. I start tmux with this in my .bashrc.

@denten
Copy link

@denten denten commented May 14, 2017

Thanks @algesten. Tmux has the potential to lock up the system when logging in without a display/login manager due to the way it attaches to x / screens. My .bashrc looked more or less the same as yours. Both Arch and Debian wikis discuss the problem and warn against starting tmux automatically with each bash session. I manged to fix it on my system with much effort (launch Arch from USB, mount drive, revert the .bashrc changes).

My point is that starting tmux on each session just for scrollback is far from "simple" as the Readme suggests. It has pretty significant and non-obvious side effects which include affecting system login behavior and clipboard behavior.

Sessions are another point of complexity. Tmux is not really made to be managed externally. Like many users, I launch and kill hundreds of terminal windows, where I do not want to attach to an existing session. This quickly results in a mountain of abandoned Tmux sessions. I am sure it is possible to figure a way out of it, or to change the way I use my window manager, but that is not really the point. I just want scrollback, not the added baggage of a complex and powerful tool like Tmux.

I am adding these notes to help developers understand the effects of their design decision not to include a basic feature like scrollback. In my case, after losing about a day on battling w/ Alacritty, I went back to gnome-terminal (which by the way is pretty fast in its own right).

@torpak
Copy link

@torpak torpak commented May 23, 2017

@denten it seems the decision that scrollback will be accepted as an alacritty feature is done.
As i understand it, it's just a matter of someone finding the time to do the work.

@jwilm
Copy link
Collaborator

@jwilm jwilm commented May 23, 2017

@torpak that's right!

zetok added a commit to zetok/alacritty that referenced this issue May 31, 2017
@CosmicToast
Copy link

@CosmicToast CosmicToast commented Jun 5, 2017

re: starting tmux in bashrc, I simply maintain two shortcuts:
$TERMINAL -e tmux to open a terminal with tmux.
$TERMINAL to open a terminal without it.

This fixes both issues given:

  1. You cannot lock yourself out if by default you're not launching tmux (of course, your default shortcut does)
  2. Abandoned sessions are no longer needed - if you're just planning to attach to an existing session, you can use the 2nd shortcut and immediately exec tmux a...

This isn't an issue with tmux not being made to be managed externally, but rather not intended to be shoehorned into something that's meant to be initializing your shell - putting anything of that sort in there is bound to potentially cause similar problems.

Mostly leaving this here for people that assume that adding some line to their rcs is the one-true-way™️ to launch tmux, and are weary of the issues that are bound to come along if one does that.

@a1russell
Copy link

@a1russell a1russell commented Jul 1, 2017

Would there be a possibility of integrating with tmux for this scrollback, similar to how iTerm2 does it, and also planned to be implemented by Terminator?

@neon64
Copy link

@neon64 neon64 commented Jul 3, 2017

@jwilm I've been trying to take your suggestion "Maybe the Grid should become a view into the scroll/line buffer?" on board, and see if it will work when the Grid is a view into a VecDeque. I chose VecDeque because it I can push_back to add new lines and then pop_front to remove the oldest entries once the buffer reaches a defined maximum length (eg: 10,000). However I must admit I know nothing about the internals of these data structures and therefore probably can't aim for optimum performance. Already I fear that VecDeque will be problematic because the memory isn't contiguous so I can't slice it etc...

The other issue I've encountered, is that other terminals (eg: Gnome Terminal) store lines unwrapped (so that upon changing screen size the text can be rewrapped easily), whereas Alacritty doesn't. Its not really a dealbreaker for me, but I thought I'd just point it out because a fix could be part of this scrollback implementation.

Final question, are we aiming for line-by-line or pixel-by-pixel scrolling?Of course pixel-by-pixel looks nicer, but would likely require a bit more work (including modifying the renderer to take a pixel offset, rather than just changing terminal grid impl). Edit: Personally I'm all for pixel because I love eye-candy

@maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Jul 3, 2017

Could the idea to integrate with tmux be discussed as well? It sounds really interesting to have one scrollback instead of two independent ones, but I see quite a few 👎 - what are the drawbacks of that approach?

@aeosynth
Copy link

@aeosynth aeosynth commented Jul 3, 2017

What needs integrating? Tmux can already provide scrollback to alacritty. Additional integration will do nothing to help people who don't use tmux.

@RedHatter
Copy link

@RedHatter RedHatter commented Mar 7, 2018

@zakora I second that.

@jedahan
Copy link
Contributor

@jedahan jedahan commented Mar 7, 2018

Is it possible this conflicts with the alacritty as a library branch?

Thats the main thing I could think that would hold back this merge...

@jwilm jwilm mentioned this issue Mar 9, 2018
@andradei
Copy link

@andradei andradei commented Apr 3, 2018

Why would it be an issue for alacritty as a library? Can't the library functionality exists regardless of the scrolling feature?

@jedahan
Copy link
Contributor

@jedahan jedahan commented Apr 3, 2018

It was just speculation

@andradei
Copy link

@andradei andradei commented Apr 4, 2018

Gotcha, I thought there was an actual limitation there and, if it did, I'd like to know.

@Sas-18
Copy link

@Sas-18 Sas-18 commented Apr 29, 2018

Another +1 here for built-in scrollback. I don't mind whether it's an opt-in or not.

Currently building @neon64's scrollback commit to see how that works for me. Will report back later.

@zakora
Copy link

@zakora zakora commented Apr 29, 2018

@Sas-18, you may want to try out the scrollback feature from PR #1147 . I am currently running it (on commit 0d56818) without any issues.

@Sas-18
Copy link

@Sas-18 Sas-18 commented Apr 29, 2018

@zakora you read my mind; have already tried it :) (running it right now) and it works great, as far as the scrolling goes. For the record, Neon64's scrollback implementation also appeared to work well for me; I didn't do any performance testing or compare the two implementations, but given that (if I understand) the development is going in a direction NOT the Neon64 implementation, I'll continue to work with the jwilm scrollback branch for the time being.
It works really nice, except the bug which makes it not render if it loses focus :/ I'm possibly writing an issue about it now, as it doesn't quite match symptoms of the similar Issues regarding not rendering.

@sajattack
Copy link

@sajattack sajattack commented May 6, 2018

So how do I scroll? I'm confused. Mouse wheel does nothing.

@chrisduerr
Copy link
Collaborator

@chrisduerr chrisduerr commented May 7, 2018

As long as this issue is still open, alacritty does not yet implement scrollback in the master branch.

@andradei
Copy link

@andradei andradei commented May 8, 2018

@sajattack If you take the time to read from the first comment in this issue it points to scrolling by using tmux. If you don't know what it is, look it up, it is a terminal multiplexer.

@abelianring
Copy link

@abelianring abelianring commented May 16, 2018

Hopefully scrollback will be optional. I'm using Alacritty mostly because it doesn't have scrollback.

@chrisduerr
Copy link
Collaborator

@chrisduerr chrisduerr commented May 16, 2018

@yegortimoshenko The scrollback history size is already completely up to the user to choose. So it's already possible to disable scrollback history, no worries! :)

@Vvkmnn
Copy link

@Vvkmnn Vvkmnn commented Jun 22, 2018

Would love the option. The faux scrollback in Vim works really natively, and its always a surprise when there's a stack trace to big for my window. Looking forward to trying this setup via #1147.

@cedws
Copy link

@cedws cedws commented Aug 5, 2018

Any idea when this will be merged? It's been open quite a while now 😄. Thanks!

@chrisduerr
Copy link
Collaborator

@chrisduerr chrisduerr commented Aug 5, 2018

From a technical perspective I think most issues on scrollback are resolved. A longer testing period is always a good thing but as far as I know this branch already has a fair share of users.

At this point it comes down to jwilm when scrollback is ready for merging. I'm not aware of anything that can be done to accelerate the process by anyone else.

@shazow
Copy link

@shazow shazow commented Aug 5, 2018

I've been using the scrollback branch for a few weeks and haven't had any problems at all! It might be difficult to get a sense of exactly how many people are using it, but I imagine the number is non-trivial.

Perhaps people can add a reaction to this comment if you're already using the scrollback branch?

@chrisduerr
Copy link
Collaborator

@chrisduerr chrisduerr commented Aug 5, 2018

Thanks for the feedback @shazow, it's always easier to see when things are broken than when things are working well. So feedback like this is much appreciated.

@cedws
Copy link

@cedws cedws commented Aug 5, 2018

I've just checked out the latest version of this branch, compiled and installed it with cargo deb. I have been running an old version of this branch for quite some time.

Having a few problems. I've noticed that holding down keys doesn't work. The window also has a strange decoration with red/yellow/green buttons in the top right. Additionally, cargo deb gets stuck when running it for a second time, and I had to cargo clean unfortunately.

@kpcyrd
Copy link

@kpcyrd kpcyrd commented Aug 5, 2018

@c-edw can you verify those problems are specific to the scrollback branch?

@cedws
Copy link

@cedws cedws commented Aug 5, 2018

@kpcyrd Nope, they're on master too, not sure why I thought it was restricted to scrollback.

@nirfse
Copy link

@nirfse nirfse commented Aug 5, 2018

@c-edw

The window also has a strange decoration with red/yellow/green buttons in the top right.

Hey, it seems that you're using Linux with Wayland (default on latest Gnome DE and some Linux distros). If that's the case, you should run Alacritty with Wayland-backend disabled as stated in the "Edit" of this reply: #97 (comment) (env WAYLAND_DISPLAY= alacritty).

@cedws
Copy link

@cedws cedws commented Aug 5, 2018

@nirfse Thanks for the info. I remember having to do this a while ago. Unfortunately, I'm now getting Illegal instruction (core dumped) when running it like this, even though the workaround worked fine before. This issue is on master though, don't let it halt anything here 😄.

@chrisduerr
Copy link
Collaborator

@chrisduerr chrisduerr commented Aug 6, 2018

@c-edw That was a build error due to one of our dependencies. It has already been resolved on both master and scrollback.

@cedws
Copy link

@cedws cedws commented Aug 6, 2018

@chrisduerr Great, works! Everything seems to be working for me then, I will continue to test the scrollback branch until it is merged.

@yapbreak
Copy link

@yapbreak yapbreak commented Aug 18, 2018

Hi all,
I just wanna say thank you for this feature. I use it since january as my primary terminal and I never find an issue in my daily use of it.
I use AUR package alacritty-scrollback-git with Xorg installed.

@jwilm jwilm closed this in #1147 Sep 17, 2018
@NotAFile
Copy link

@NotAFile NotAFile commented Sep 17, 2018

for context #1147 added scrollback. This was the alacritty blocker for me, I can't wait to use it! Thanks for the hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.