Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable building without X11 for Wayland-only systems #3340

Closed
trilean opened this issue Feb 14, 2020 · 4 comments · Fixed by #3436
Closed

enable building without X11 for Wayland-only systems #3340

trilean opened this issue Feb 14, 2020 · 4 comments · Fixed by #3436
Assignees
@kchibisov
Labels
A - deps A - rust DS - Wayland DS - X11

Comments

@trilean
Copy link

trilean commented Feb 14, 2020

Hi,

I wanted to build Alacritty on a Gentoo box that doesn't have any X11 libs installed. This failes because some X libs are linked to.

I tried to brute-force my way around this by removing all X-related dependencies and code. Unfortunately I'm stuck at

alacritty/alacritty/src/main.rs

Line 169 in 988a846

let pty = tty::new(&config, &display.size_info, display.window.x11_window_id());

because there's no waylandish version of this implemented.

Any help in getting this awesome terminal running on Wayland-only is very much appreciated 😉
Thanks!
@kchibisov
Copy link
Member

you can take a look on upstream issue right there rust-windowing/winit#774 .

@kchibisov
Copy link
Member

kchibisov commented Mar 6, 2020 •
edited
Loading

Actually I feel like there's no need to disable something in winit. It seems like we can achieve it just inside alacritty.

@kchibisov kchibisov self-assigned this Mar 6, 2020
kchibisov added a commit to kchibisov/alacritty that referenced this issue Mar 9, 2020
@kchibisov
Add option to pick Linux/BSD backends
e5ff483 
Fixes alacritty#3340.
@kchibisov kchibisov mentioned this issue Mar 9, 2020
Merged
@kchibisov
Copy link
Member

If someone is interested in testing the build it'll be nice to check #3436. Instructions are on the PR.

@nixpulvis
Copy link
Contributor

Not directly related to this fix... But FWIW, I left a comment on rust-lang/cargo#5015 (comment), and opened a thread Rust Internals - Features and Workspaces, Request for Meta Issue.

kchibisov added a commit to kchibisov/alacritty that referenced this issue Mar 12, 2020
@kchibisov
Add option to pick Linux/BSD backends
f091d8b 
Fixes alacritty#3340.
kchibisov added a commit that referenced this issue Mar 13, 2020
@kchibisov
Add option to pick Linux/BSD backends
4000ec0 
This commit adds two cargo features `x11` and `wayland` to pick
Linux/BSD backends, with both enabled by default.

Fixes #3340.
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Mar 14, 2020
@gyakovlev
x11-terms/alacritty: bump to 0.4.2_rc1
3471c8c 
install man page
introduce X and wayland useflags, this should allow
to have alacritty without most X related dependencies on wayland-only
systems

See: alacritty/alacritty#3340
See: alacritty/alacritty#3436
Package-Manager: Portage-2.3.93, Repoman-2.3.20
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
roychoo pushed a commit to roychoo/alacritty that referenced this issue Apr 19, 2020
@kchibisov @roychoo
Add option to pick Linux/BSD backends
de8d70d 
This commit adds two cargo features `x11` and `wayland` to pick
Linux/BSD backends, with both enabled by default.

Fixes alacritty#3340.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kchibisov kchibisov

Labels
A - deps A - rust DS - Wayland DS - X11
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to pick Linux/BSD backends kchibisov/alacritty
3 participants
@nixpulvis @trilean @kchibisov