Add support for hyperlink escape sequence #6139
Conversation
kchibisov
force-pushed
the
hyperlink-v2
branch
2 times, most recently
from
80a71c4 to
b8f5d02
Compare
1 similar comment
|
|
|
@chrisduerr seems like I've managed to fix it. That's pretty interesting though, increasing the amount of attrs changed the way it gets optimized. Might consider splitting it even more, like moving color, etc related parts to a separate methods keeping attr in something like u8. |
kchibisov
force-pushed
the
hyperlink-v2
branch
2 times, most recently
from
31430b8 to
88f3e9d
Compare
kchibisov
force-pushed
the
hyperlink-v2
branch
2 times, most recently
from
599f2ed to
41776d5
Compare
|
|
|
I've implemented an iterator for string shortening. Should work now in both directions and place a shoretener for regex strings in search bar. |
There was a problem hiding this comment.
I like the StrShortener implementation, in raw LoC count it might be a little more verbose but it's very descriptive and does what it's supposed to do well and clearly.
Could also easily be moved to another module if we want to reduce LoC count in display/mod.rs, which probably wouldn't be a terrible idea?
This commit adds support for hyperlink escape sequence `OSC 8 ; params ; URI ST`. The configuration option responsible for those is `hints.enabled.hyperlinks`. Fixes alacritty#922.
|
This is exciting! Thanks for all the hard work on this!! 🙌 |
The end of the search window is currently calculated using the viewport start instead of the end. The observed behavior is that all hinting stops suddenly after line 101. This was introduced in #6139 when the code was refactored into this file from display/content.rs.
|
How does this work? Is it released? I tried to build from master and then executed: printf '\e]8;;http://example.com\e\\This is a link\e]8;;\e\\\n'It did not produce a clickable link. |
Part of You could test with default config Won't work in tmux unless you build it from master. Likely won't work on Windows, since ConPty. |
This commit adds support for hyperlink escape sequence
OSC 8 ; params ; URI ST.Fixes #922.