Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Breaking: comma-dangle enable functions: "never" (fixes eslint#11502)
  • Loading branch information
aladdin-add committed Mar 17, 2019
1 parent 06fa165 commit e8a027e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion docs/rules/comma-dangle.md
Expand Up @@ -69,7 +69,6 @@ The default for each option is `"never"` unless otherwise specified.
* `imports` is for import declarations of ES Modules. (e.g. `import {a,} from "foo";`)
* `exports` is for export declarations of ES Modules. (e.g. `export {a,};`)
* `functions` is for function declarations and function calls. (e.g. `(function(a,){ })(b,);`)
* `functions` is set to `"ignore"` by default for consistency with the string option.
* `functions` should only be enabled when linting ECMAScript 2017 or higher.

### never
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/comma-dangle.js
Expand Up @@ -21,7 +21,7 @@ const DEFAULT_OPTIONS = Object.freeze({
objects: "never",
imports: "never",
exports: "never",
functions: "ignore"
functions: "never"
});

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-eslint/default.yml
Expand Up @@ -13,7 +13,7 @@ rules:
camelcase: "error"
callback-return: ["error", ["cb", "callback", "next"]]
class-methods-use-this: "error"
comma-dangle: ["error", { functions: "never" }]
comma-dangle: "error"
comma-spacing: "error"
comma-style: ["error", "last"]
computed-property-spacing: "error"
Expand Down

0 comments on commit e8a027e

Please sign in to comment.