Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thunderbird 68.0 #71

Open
caugner opened this issue Aug 29, 2019 · 42 comments

Comments

@caugner
Copy link

commented Aug 29, 2019

Unfortunately Nostalgy cannot be used with the latest version of Thunderbird anymore:

grafik

Maybe it's just the version range that needs to be updated?

@jfmc

This comment has been minimized.

Copy link

commented Aug 30, 2019

Here are some details about upgrading TB68 https://developer.thunderbird.net/add-ons/updates .

@hi5

This comment has been minimized.

Copy link

commented Aug 30, 2019

I do hope there will be a working version of nostalgy for 68+ at some point in the future, in the meantime I would need an alternative - so far the only one that seems to have some "productivity" features of nostalgy is Quickfolders - https://addons.thunderbird.net/en-US/thunderbird/addon/quickfolders-tabbed-folders/

Unfortunately the "quick move" is a paid (subscription) feature but folder (tab) shortcuts are present. At least it is being developed.

Alternatives welcome

@eliotmoss

This comment has been minimized.

Copy link

commented Aug 30, 2019

@hi5

This comment has been minimized.

Copy link

commented Aug 30, 2019

From what I can understand/see: If you pay the subscription it unlocks a shift+m (configurable) shortcut, from the inactive PRO config screen:
Clipboard

@eliotmoss

This comment has been minimized.

Copy link

commented Aug 30, 2019

@oehm-smith

This comment has been minimized.

Copy link

commented Aug 30, 2019

@alainfrisch

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2019

I much prefer hitting a single letter 'S', 'C' or 'G' (nostalgy) rather
than having to use a modifier (quick folder).

This comment https://addons.thunderbird.net/en-US/thunderbird/addon/quick-folder-move/reviews/1154733/ suggests that with the help of another extension, you might be able to configure the keys used by Quick Folder Move.

@tuxayo

This comment has been minimized.

Copy link

commented Sep 3, 2019

@alainfrisch Do you mean that you no longer have the resources to maintain Nostalgy?

If so that's fine, thanks a lot for your work. What about creating an issue to search a new maintainer?

@alainfrisch

This comment has been minimized.

Copy link
Owner

commented Sep 3, 2019

I haven't really maintained Nostalgy for the last 10 years, only applied (usually tiny) patches from contributors to tweak the code and make it work with newer releases. I suspect that the changes required now would almost amount to a full rewrite, which I certainly won't have time to even review properly. So yes, if someone wants to take over the project, I'll happily hand it over!

@tuxayo

This comment has been minimized.

Copy link

commented Sep 4, 2019

Thanks a lot for clarifying the situation and opening a way forward for the project.

@jpbarraca

This comment has been minimized.

Copy link

commented Sep 4, 2019

@tuxayo Are you going to convert nostalgy into a WebExtension? The codebase is not that large, but the number of changes is still relevant.

@tuxayo

This comment has been minimized.

Copy link

commented Sep 5, 2019

@jpbarraca Unfortunately I don't have the experience nor the time resources to work on this, it was just to clarify the situation about the maintenance and make it explicit that help is wanted.

@willsALMANJ

This comment has been minimized.

Copy link

commented Sep 5, 2019

If I understand the documentation correctly, it might be possible to get Nostalgy working with Thunderbird 68 by reworking the way it is packaged as described here. However, this might be short-term solution as the future is uncertain:

It’s difficult to say for sure what the future will hold for Thunderbird extensions. A lot of work has been done to ensure that legacy extension (overlay extension and bootstrap extensions) will work in Thunderbird 68. Beyond that, we just don’t know.

@caugner

This comment has been minimized.

Copy link
Author

commented Sep 5, 2019

@willsALMANJ Afaik XUL will be removed in the long run, which means all *.xul files in /content will almost certainly require migration sooner or later.

@jpbarraca

This comment has been minimized.

Copy link

commented Sep 5, 2019

AFAIK Components.* are also not present in WebExtensions

@opto

This comment has been minimized.

Copy link

commented Sep 6, 2019

Hello Alain,

I got major parts of nostalgy running on TB68. Actually, I started whith what I need most:

  • move messages, have autocomplete list of folders
  • remember where a message of a known owner was moved last time.

I have not yet looked at how to do preferences now so that rules can be revived.

I might be willing to take over nostalgy, because it is one of my major productivity tools in keeping order in my mailbox. Let me know what you think.

Cheers,

Klaus

@caugner

This comment has been minimized.

Copy link
Author

commented Sep 6, 2019

@opto Are you working on a fork that you could share with us? Did you start from scratch or migrated according to the official migration guide?

@alainfrisch

This comment has been minimized.

Copy link
Owner

commented Sep 6, 2019

Great news @opto! What about publishing your fork on github, and when it gets good community feedback, we'll just arrange to let you publish that new version as "Nostalgy" on the official TB addons repository.

@opto

This comment has been minimized.

Copy link

commented Sep 7, 2019

I will upload later or tomorrow what I have to github/opto:
@alain: why do you put the code into the jar? What I have has the code outside. Not sure whether jar's are supported any longer, but would like to know the reason.

@opto

This comment has been minimized.

Copy link

commented Sep 7, 2019

This is an experimental version for TB 68 in https://github.com/opto/nostalgy.
Clone folder to your harddisk. Switch to branch TB68.

Install in TB by: Tools->developer toolbox-> debug addon

Press button: install addon temporarily (at top of page)-
Goto folder, highlight manyfest.json, confirm with OK.

Modified by opto (Klaus Buecher) in https://github.com/opto/nostalgy.

Basic moving etc. works, I did not yet update preferences and its dialogs and rules.
Works only in main Thunderbird window as proof of concept. I did not yet change code for the other windows (overlays).

Klaus

@aaschmid

This comment has been minimized.

Copy link

commented Sep 7, 2019

Thanks @opto but I guess you missed to commit the new manifest.json replacing the old install.rdffile.

@opto

This comment has been minimized.

Copy link

commented Sep 7, 2019

correct. Hopefully, this is ok now

@aaschmid

This comment has been minimized.

Copy link

commented Sep 7, 2019

Your Works now for me.
Edit: At least sorting of messages. Using shift+s to move the current message again two messages got moved.
Also I have seen - even if unreproduceable for now - that deleting removes more than one message. I have no clue if this is also caused by the new version.

@opto

This comment has been minimized.

Copy link

commented Sep 9, 2019

Now B,C,G are working, also in messagewindow, but not yet L and preferences/rules

@alain

This comment has been minimized.

Copy link

commented Sep 9, 2019

@opto

This comment has been minimized.

Copy link

commented Sep 11, 2019

It is here on Win 10 home 32 bit.

What isn't working, which OS?
Klaus

@opto

This comment has been minimized.

Copy link

commented Sep 11, 2019

@aaschmid : I checked/adjusted for TB 68 just move, copy, goto folder, move an goto folder.
Actually, I tired all with s,m,b,g. I don't remember whether I tested it with multiple messages.
Please see Alain's user instruction: *Even if the key shortcuts above are written in uppercase, you must not press Shift.

At the moment, I have no idea what shift S would do and never tried it before.

L: that is a special thing. In debugger, it works. Without debugger, the same code does nothing. Nobody has an idea yet why.

For all operations, Alain uses basic TB functions. He didn't program the moving or copying but uses the internal TB functions which move or copy. So if something hangs there ... it is TB68?

@eliotmoss

This comment has been minimized.

Copy link

commented Sep 11, 2019

@opto

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks. Yes, I remember. Default folders cannot work yet because preferences do not work yet. That is one of the next things to convert to TB68.

@aaschmid

This comment has been minimized.

Copy link

commented Sep 11, 2019

Or "shift S" move to the same folder again as "s" did the operation before unless no default folder is configured for the email.
This currently moves two messages instead of only the selected one.

@opto

This comment has been minimized.

Copy link

commented Sep 12, 2019

which is the second? above, below, or just any?

I didn't look at shift S yet, so it is not supposed to work yet.

@aaschmid

This comment has been minimized.

Copy link

commented Sep 12, 2019

@opto

This comment has been minimized.

Copy link

commented Sep 13, 2019

for unknown reasons, events are done twice. Double L = toggle folders followed by toggle = nothing happens.

I assume shift S is also done twice, if yes, two messages are copied.

Edit: Got it, that's it. Will upload later today.

@moritzp

This comment has been minimized.

Copy link

commented Sep 14, 2019

For me it does the trick, at least for the features I use. I didn't come across any issue during the last week.

@tuxayo

This comment has been minimized.

Copy link

commented Sep 16, 2019

As a humble contribution, a bounty has been created: Bountysource

@lmiguelsilveira

This comment has been minimized.

Copy link

commented Sep 17, 2019

Thanks all for the extra work on this great extension.
I picked the Zip from opto, went into (this is Linux) Tools ->Developer Tools -> Debug Add-ons, then "Load Temporary" Add-on" and picked the *xpi file (built with make on the directory). It fails with the error

There was an error during installation: File <...>/nostalgy-master/nostalgy.xpi does not contain a valid manifest

There is indeed a chrone.manifest but no manifest.json file. There is an install.rdf file.
I am clearly missing something. Any suggestions/hints?
Thanks!

@opto

This comment has been minimized.

Copy link

commented Sep 17, 2019

@tuxayo: thanks.
Imiguelsilveira: the zip and xpi is still the old version. I have not yet packaged all into a new xpi.
At the moment, the only way to test and start is to do this:
Clone folder to your harddisk. Switch to branch TB68 in git.

Install in TB by: Tools->developer toolbox-> debug addon

Press button: install addon temporarily (at top of page)-
Goto folder, highlight manyfest.json, confirm with OK.

After I make the xpi, it can be installed the normal way (I hope...)
Klaus

@terry8471

This comment has been minimized.

Copy link

commented Sep 19, 2019

Not having Nostalgy working in 68 is the dealbreaker for me. I'd hold on to 60 as long as I could. I can't describe how happy I am that Nostalgy is not abandoned afterall. Thanks to the Klaus and the community.

@obfischer

This comment has been minimized.

Copy link

commented Sep 19, 2019

I added 50$ to the bounty. I can't imaging to use Thunderbird without Nostalgy.

@RainerKlute

This comment has been minimized.

Copy link

commented Sep 20, 2019

I just added another $20 to the bounty. Nostalgy is simply indispensable for me! Looking forward to the slick Linux install!

@cdhooper

This comment has been minimized.

Copy link

commented Sep 21, 2019

I added $50 to the bounty -- Nostalgy's ability to 'm' move messages to folders and 'g' go to folders are the only way I can manage all my email. In the meantime, I'll continue using a downrev version of Thunderbird (on Linux). Thank you @alainfrisch and @opto!

@obfischer

This comment has been minimized.

Copy link

commented Sep 21, 2019

Will the changes made by @opto be merged to this repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.