Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What parts of MLJBase should be reexported in MLJ #462

Closed
vollmersj opened this issue Feb 28, 2020 · 2 comments
Closed

What parts of MLJBase should be reexported in MLJ #462

vollmersj opened this issue Feb 28, 2020 · 2 comments

Comments

@vollmersj
Copy link
Collaborator

I noticed StaticTransformer has remainded in MLJBase whereas as all other transformer moved to MLJModels. So if you do

using MLJ
using MLJModels

you still dont have access to StatiticTransformer. This could be simply fixed with export in MLJ.jl

@juliohm
Copy link
Contributor

juliohm commented Feb 28, 2020 via email

@ablaom
Copy link
Collaborator

ablaom commented Mar 2, 2020

@sjvollmer StaticTransformer is no longer meant for general use. Use Static instead.

Sorry the docs are bit buried at https://alan-turing-institute.github.io/MLJ.jl/dev/composing_models/#Static-operations-on-nodes-1 but #393 should fix this.

@juliohm I don't believe we just re-export every submodule method, so this is not a simple refactor.

@ablaom ablaom closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants