Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appveyor #1541

Merged
merged 13 commits into from Oct 20, 2021
Merged

Fix appveyor #1541

merged 13 commits into from Oct 20, 2021

Conversation

freddyaboulton
Copy link
Collaborator

Reference Issues/PRs

Fixes #1539

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@fkiraly
Copy link
Collaborator

fkiraly commented Oct 19, 2021

this ... seems to have worked? 😮

@freddyaboulton
Copy link
Collaborator Author

freddyaboulton commented Oct 19, 2021

@fkiraly I believe so! Will open it up for review now.

@freddyaboulton freddyaboulton marked this pull request as ready for review October 19, 2021 20:00
@fkiraly
Copy link
Collaborator

fkiraly commented Oct 19, 2021

and only 12 characters change... really an odd story.

Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks @freddyaboulton

@freddyaboulton freddyaboulton changed the title Try to fix appveyor Fix appveyor Oct 19, 2021
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once more, @freddyaboulton had saved the day."

@fkiraly fkiraly merged commit 00b71fa into sktime:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] failing appveyor/windows builds
3 participants