Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Remove pytest-xdist from CI-CD, un-skip test_multiprocessing_idempotent #2004

Merged
merged 2 commits into from Feb 7, 2022

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Feb 6, 2022

Update: upgrading this from a draft.

This PR removes pytest-xdist from CI-CD and adds back test_multiprocessing_idempotent.

This is based on the observation/conclusion that pytest-xdist is causing multiple strange interactions which lead to crashes and erroring out of our CI-CD under hard to specify conditions.

Implements #2012 (also see there for further details)


Draft, attempt at diagnosing #1941 - removing pytest-xdist.

Also adds back test_multiprocessing_idempotent to see what happens.

@fkiraly fkiraly changed the title DRAFT for diagnosint CI/CD: Remove pytest xdist DRAFT for diagnosing CI/CD: Remove pytest-xdist Feb 6, 2022
@fkiraly fkiraly marked this pull request as ready for review February 7, 2022 01:32
@fkiraly fkiraly changed the title DRAFT for diagnosing CI/CD: Remove pytest-xdist [MNT] Remove pytest-xdist from CI-CD, un-skip test_multiprocessing_idempotent Feb 7, 2022
@fkiraly fkiraly added bug Something isn't working maintenance Continuous integration, unit testing & package distribution labels Feb 7, 2022
@fkiraly fkiraly merged commit 1f52bb6 into main Feb 7, 2022
@fkiraly fkiraly deleted the remove-pytest-xdist branch February 7, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Continuous integration, unit testing & package distribution
Development

Successfully merging this pull request may close these issues.

None yet

2 participants