New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] extending reducers to hierarchical data #2396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notebook is failing - related to the bug in |
…institute/sktime into make_reduction_hier
srggrs
added a commit
to Gridsight/sktime
that referenced
this pull request
Apr 11, 2022
* upstream/main: (34 commits) Update codecov uploader from deprecated version and cosmetic improvements of CI scripts. (sktime#2389) bump version (sktime#2445) Fix typo in PULL_REQUEST_TEMPLATE.md (sktime#2446) [BUG] Incorrect indices returned by make_reduction on hierarchical data fixed (sktime#2438) [BUG] fix erroneous direct passthrough in ColumnEnsembleForecaster (sktime#2436) [BUG] forecasting pipeline dunder fix (sktime#2431) [BUG] temp workaround for unnamed levels in hierarchical X passed to aggregator (sktime#2432) Release v0.11.1 (sktime#2428) [ENH] extending reducers to hierarchical data, add transform-on-y functionality (sktime#2396) [ENH] interface to statsmodels SARIMAX interface (sktime#2400) [BUG] fixed fitting logic for postprocessing in `TransformedTargetForecaster` (sktime#2426) [BUG] `TransformedTargetForecaster` inverses were not working for univariate transformers and more than one quantile (sktime#2425) [BUG] fixing proba predict methods of forecasting tuning estimators (sktime#2423) [ENH] suppressing deprecation messages in `all_estimators` estimator retrieval, address `dtw` import message (sktime#2418) [BUG] fixed `score_average` parameter of proba metrics, docstrings (sktime#2401) [BUG] Sets "can handle missing value" tag in ARIMA and AutoARIMA (sktime#2420) [ENH] tests for `check_estimator` tests passing (sktime#2408) [ENH] post-processing in `TransformedTargetForecaster`, dunder method for (transformed `y`) forecasting pipelines (sktime#2404) [ENH] extend `_HeterogeneousMetaEstimator` estimator to allow mixed tuple/estimator list (sktime#2406) [BUG] fixed get_time_index for most mtypes (sktime#2380) ...
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step to enable global forecasting via an efficient application of make_reduction using the new argument transformers.
I will do some refactoring, introduce checks etc., but already posted to discuss implementation strategy, see below.
Example use case
Open questions:
What kind of arguments do we want to use in transformers? Currently I can only think about WindowSummarizer, but we could of course apply any kind of function where we want a grouped application. Currently only the first transformer in the list is applied (I will extend this after we resolved the open implementation question)
What is currently best practice to apply an Imputer across the different y time series grouped together in pd-multiindex? Should that also be covered here?