[ENH] tests for check_estimator tests passing
#2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
module:tests
fkiraly
added this to In progress - testing module
in Workstream: docs, maintenance, testing
lmmentel
added
the
maintenance
srggrs
added a commit
to Gridsight/sktime
that referenced
this pull request
Apr 11, 2022
* upstream/main: (34 commits) Update codecov uploader from deprecated version and cosmetic improvements of CI scripts. (sktime#2389) bump version (sktime#2445) Fix typo in PULL_REQUEST_TEMPLATE.md (sktime#2446) [BUG] Incorrect indices returned by make_reduction on hierarchical data fixed (sktime#2438) [BUG] fix erroneous direct passthrough in ColumnEnsembleForecaster (sktime#2436) [BUG] forecasting pipeline dunder fix (sktime#2431) [BUG] temp workaround for unnamed levels in hierarchical X passed to aggregator (sktime#2432) Release v0.11.1 (sktime#2428) [ENH] extending reducers to hierarchical data, add transform-on-y functionality (sktime#2396) [ENH] interface to statsmodels SARIMAX interface (sktime#2400) [BUG] fixed fitting logic for postprocessing in `TransformedTargetForecaster` (sktime#2426) [BUG] `TransformedTargetForecaster` inverses were not working for univariate transformers and more than one quantile (sktime#2425) [BUG] fixing proba predict methods of forecasting tuning estimators (sktime#2423) [ENH] suppressing deprecation messages in `all_estimators` estimator retrieval, address `dtw` import message (sktime#2418) [BUG] fixed `score_average` parameter of proba metrics, docstrings (sktime#2401) [BUG] Sets "can handle missing value" tag in ARIMA and AutoARIMA (sktime#2420) [ENH] tests for `check_estimator` tests passing (sktime#2408) [ENH] post-processing in `TransformedTargetForecaster`, dunder method for (transformed `y`) forecasting pipelines (sktime#2404) [ENH] extend `_HeterogeneousMetaEstimator` estimator to allow mixed tuple/estimator list (sktime#2406) [BUG] fixed get_time_index for most mtypes (sktime#2380) ...
fkiraly
moved this from In progress - testing module
to Done
in Workstream: docs, maintenance, testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests to test that tests conducted by the
check_estimatorutlity are passing, on three example estimators that are known to pass all tests in the full test suite.This ensures that future tests catch unintentional side effects to changes in the test module that cause a
check_estimatortest to fail, such as the problem addressed recently in #2405Also turns some instances of
pytest.skipinside tests intoreturn None, as that currently breakscheck_estimator. An issue to replace this workaroudn has been opened here: #2419