Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fixed bug where no average params passed #2592

Merged
merged 5 commits into from May 2, 2022
Merged

Conversation

chrisholder
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes.

There was a bug that caused kmeans to crash if average_params wasn't passed to the clusterer. This pr adds an additional check to stop it from crashing if None is passed.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [DOC] or [BUG] indicating whether the PR topic is related to enhancement, documentation or bug
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@chrisholder chrisholder merged commit c12864e into main May 2, 2022
@chrisholder chrisholder deleted the dba-bug-fix branch May 2, 2022 17:03
@lmmentel lmmentel added the bugfix Fixes a known bug or removes unintended behavior label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants