Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] reserved variables listed in extension templates #2769

Merged
merged 3 commits into from Jun 11, 2022

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jun 9, 2022

This adds a list of reserved variables to the instructions in the extension templates, to avoid accidental write to reserved variables by implementers of estimators.

FYI @miraep8 (#2738 was an example of this accident)

@fkiraly fkiraly added the documentation Documentation & tutorials label Jun 9, 2022
@fkiraly fkiraly mentioned this pull request Jun 9, 2022
4 tasks
@fkiraly fkiraly merged commit 4e56c6a into main Jun 11, 2022
@fkiraly fkiraly deleted the extension_template_reserved_vars branch June 11, 2022 17:07
fkiraly added a commit that referenced this pull request Jun 12, 2022
…sters_` (#2771)

This fixes a clash between `forecasters_` attribute from `BaseForecaster` (from vectorization) and the `forecasters_` from `MultiplexForecaster`, as pointed out by @miraep8, see #2769.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants