42 num rows per pass #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-band
added a commit
to tim-band/sqlsynthgen
that referenced
this pull request
Jun 11, 2025
* test_make updated test_settings fixed * Fixed main and create tests * Tests all pass individually now. Many fixes: * create-vocab actually runs * create-data reports correct count of story rows * -f can be used as well as --force * the logger is called "datafaker" not "utils" * row generators can fully exhaust unique constraints * row/story generator modules can just be files (this may just have been broken for tests) * turning on max constraint retries doesn't break create-data * unique constraint failure does not blow up datafaker * More test robustness * All test pass together! Row generators can be instantiated objects --------- Co-authored-by: Tim Band <t.b@ucl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
num_rows_per_pass: 2entry in the config .yaml into anum_rows_per_pass = 2member variable in the generator class when we domake-generators ....create-data ....