Skip to content

Probably won't compile with GCC 10 on Linux (-fcommon issue) #14

Description

@vain

GCC 10 changed the default from -fcommon to -fno-common:

https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

I haven't tested this with your version of Mosaic, only with another fork (https://github.com/yotann/ncsa-mosaic -- because it has been ported to a newer version of libpng, see #8). IMO, it's more than likely that it affects your version as well (I don't see any relevant differences between the two) and wanted to let you know.

One blunt workaround is to add -fcommon:

diff --git a/makefiles/Makefile.linux b/makefiles/Makefile.linux
index 2cea009..ad03902 100755
--- a/makefiles/Makefile.linux
+++ b/makefiles/Makefile.linux
@@ -225,7 +225,7 @@ customflags =
 
 # ---------------------- END OF CUSTOMIZABLE OPTIONS -------------------------
 
-CFLAGS = -g $(sysconfigflags) $(prereleaseflags)
+CFLAGS = -fcommon -g $(sysconfigflags) $(prereleaseflags)
 
 # Don't worry about these -- for development purposes only.
 PURIFY = purify

As the Gentoo wiki points out, though, this is not an ideal solution. It also outlines nicely what should be done instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions