Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rewrite of enable-text-selection.js and add text-selection-demo.html #5
Alan, thanks for the invite to submit a pull request. I rewrote
Limitations of the previous version that I've attempted to address with my rewrite:
Note: This is my first attempt at pushing and generating a pull request. Let me know if I break any rule or convention
Hey @RoxKilly, my apologies for having missed this PR at first. I haven't been super on top of my personal email inbox.
I really appreciate a lot about this pull request:
I left a comment regarding a potential improvement — I’m not sure if it’s straightforwardly possible, though — but I’m happy to merge this now and release it to better help users of the bookmarklet.
Thanks so much.