New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate configuration and credential management #485

Closed
wants to merge 1 commit into
base: dev
from

Conversation

Projects
None yet
2 participants
@rnelson0
Contributor

rnelson0 commented Sep 7, 2016

New functions Store-vCenterCredentials and Retrieve-vCenterCredentials.
End vCheck after configuration when running in configuration mode.
Store credentials securely on disk so that users do not need to hand edit the plugins on installation.
When credentials are not available, prompt for credentials (preserve current behavior for existing users).
gitignore the new vCenter credentials file.
Prevent modified files from being mojibaked by little endian BOMs (http://stackoverflow.com/questions/10655788/powershell-set-content-and-out-file-what-is-the-difference)

Automate configuration and credential management
  New functions Store-vCenterCredentials and Retrieve-vCenterCredentials.
  End vCheck after configuration when running in configuration mode.
  Store credentials securely on disk so that users do not need to hand edit the plugins on installation.
    When credentials are not available, prompt for credentials (preserve current behavior for existing users).
  gitignore the new vCenter credentials file.
  Prevent modified files from being mojibaked by little endian BOMs (http://stackoverflow.com/questions/10655788/powershell-set-content-and-out-file-what-is-the-difference)
@vScripter

This comment has been minimized.

Show comment
Hide comment
@vScripter

vScripter Mar 22, 2017

Collaborator

@rnelson0 I'm going to close this PR and ask that you re-open it, for a couple of reasons:

  • I'm doing some cleanup and there have been a number of changes since you first opened this, last year; I think it's going to be easier to start fresh with a new PR
  • Couple of comments about the proposed changes:
    • Write-Host - Can you replace that with either Write-Warning or Write-Verbose - We're trying to migrate away from using Write-Host
    • Function Names - Can you rename your proposed function names to use approved verbs?

Thanks!

Collaborator

vScripter commented Mar 22, 2017

@rnelson0 I'm going to close this PR and ask that you re-open it, for a couple of reasons:

  • I'm doing some cleanup and there have been a number of changes since you first opened this, last year; I think it's going to be easier to start fresh with a new PR
  • Couple of comments about the proposed changes:
    • Write-Host - Can you replace that with either Write-Warning or Write-Verbose - We're trying to migrate away from using Write-Host
    • Function Names - Can you rename your proposed function names to use approved verbs?

Thanks!

@vScripter vScripter closed this Mar 22, 2017

@rnelson0

This comment has been minimized.

Show comment
Hide comment
@rnelson0

rnelson0 Mar 22, 2017

Contributor

Are Set- and Get-vCenterCredentials acceptable?

Contributor

rnelson0 commented Mar 22, 2017

Are Set- and Get-vCenterCredentials acceptable?

@vScripter

This comment has been minimized.

Show comment
Hide comment
@vScripter

vScripter Mar 22, 2017

Collaborator

Yep, those will work 👍🏻 (anything in the list of approved verbs: Get-Verb | Sort Verb)

Collaborator

vScripter commented Mar 22, 2017

Yep, those will work 👍🏻 (anything in the list of approved verbs: Get-Verb | Sort Verb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment