From f82da821f5f3aea240ba70f57c23ddaa342ca5a8 Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Mon, 5 Aug 2019 14:32:10 +0200 Subject: [PATCH 1/6] update deps and devdeps --- package.json | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 18628ac..63d1916 100644 --- a/package.json +++ b/package.json @@ -25,23 +25,23 @@ "LICENCE" ], "dependencies": { - "async": "^2.0.1", + "async": "^3.1.0", "cli-color-tty": "^2.0.0", "cli-table": "^0.3.1", "exit": "^0.1.2", "minimist": "^1.1.0", - "npm": "^4.0.3", - "semver": "^5.3.0", + "npm": "^6.10.2", + "semver": "^6.3.0", "xtend": "^4.0.0" }, "devDependencies": { - "coveralls": "^2.11.12", - "istanbul": "^0.4.0", - "jshint": "^2.5.1", - "rewire": "^2.1.0", - "rimraf": "^2.5.4", - "standard": "^10.0.2", - "tape": "^4.0.0" + "coveralls": "^3.0.5", + "istanbul": "^0.4.5", + "jshint": "^2.10.2", + "rewire": "^4.0.1", + "rimraf": "^2.6.3", + "standard": "^13.1.0", + "tape": "^4.11.0" }, "engines": { "node": ">=0.10.1" From e075209096c73df5f117d75dd001a0232900476e Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Mon, 5 Aug 2019 14:37:02 +0200 Subject: [PATCH 2/6] lint: add spaces after { and before } --- bin/david.js | 26 +++++++++++++------------- lib/david.js | 6 +++--- test/cli.js | 2 +- test/david.js | 18 +++++++++--------- 4 files changed, 26 insertions(+), 26 deletions(-) diff --git a/bin/david.js b/bin/david.js index a40c39c..4c01361 100755 --- a/bin/david.js +++ b/bin/david.js @@ -41,9 +41,9 @@ function printWarnings (deps, type) { if (!Object.keys(deps).length) return var warnings = { - E404: {title: 'Unregistered', list: []}, - ESCM: {title: 'SCM', list: []}, - EDEPTYPE: {title: 'Non-string dependency', list: []} + E404: { title: 'Unregistered', list: [] }, + ESCM: { title: 'SCM', list: [] }, + EDEPTYPE: { title: 'Non-string dependency', list: [] } } for (var name in deps) { @@ -59,7 +59,7 @@ function printWarnings (deps, type) { if (!warnList.length) return - var table = new Table({head: ['Name', 'Message'], style: {head: ['reset']}}) + var table = new Table({ head: ['Name', 'Message'], style: { head: ['reset'] } }) console.log(clc.underline(warnings[warnType].title + ' ' + (type ? type + 'D' : 'd') + 'ependencies') + '\n') warnList.forEach(function (row) { table.push(row) }) @@ -91,7 +91,7 @@ function printDeps (deps, type) { console.log(clc.underline('dependencies')) } - var table = new Table({head: ['Name', 'Package', 'Latest'], style: {head: ['reset']}}) + var table = new Table({ head: ['Name', 'Package', 'Latest'], style: { head: ['reset'] } }) nonWarnDepNames.forEach(function (name) { var dep = deps[name] @@ -142,16 +142,16 @@ function getUpdatedDeps (pkg, cb) { } if (argv.registry) { - opts.npm = {registry: argv.registry} + opts.npm = { registry: argv.registry } } david.getUpdatedDependencies(pkg, opts, function (err, deps) { if (err) return cb(err) - david.getUpdatedDependencies(pkg, xtend(opts, {dev: true}), function (err, devDeps) { + david.getUpdatedDependencies(pkg, xtend(opts, { dev: true }), function (err, devDeps) { if (err) return cb(err) - david.getUpdatedDependencies(pkg, xtend(opts, {optional: true}), function (err, optionalDeps) { + david.getUpdatedDependencies(pkg, xtend(opts, { optional: true }), function (err, optionalDeps) { cb(err, filterDeps(deps), filterDeps(devDeps), filterDeps(optionalDeps)) }) }) @@ -184,7 +184,7 @@ function installDeps (deps, opts, cb) { return !deps[depName].warn }) - var npmOpts = {global: opts.global} + var npmOpts = { global: opts.global } // Avoid warning message from npm for invalid registry url if (opts.registry) { @@ -212,7 +212,7 @@ function installDeps (deps, opts, cb) { } if (argv.global || argv.g) { - var opts = {global: true} + var opts = { global: true } // Avoid warning message from npm for invalid registry url if (argv.registry) { @@ -296,7 +296,7 @@ if (argv.global || argv.g) { } if (argv.update) { - var opts = {save: true, registry: argv.registry, path: pkgDir} + var opts = { save: true, registry: argv.registry, path: pkgDir } installDeps(deps, opts, function (err) { if (err) { @@ -304,13 +304,13 @@ if (argv.global || argv.g) { exit(1) } - installDeps(devDeps, xtend(opts, {dev: true}), function (err) { + installDeps(devDeps, xtend(opts, { dev: true }), function (err) { if (err) { console.error('Failed to update/save devDependencies', err) exit(1) } - installDeps(optionalDeps, xtend(opts, {optional: true}), function (err) { + installDeps(optionalDeps, xtend(opts, { optional: true }), function (err) { if (err) { console.error('Failed to update/save optionalDependencies', err) exit(1) diff --git a/lib/david.js b/lib/david.js index 253fadb..f330597 100644 --- a/lib/david.js +++ b/lib/david.js @@ -127,7 +127,7 @@ function getDependencies (manifest, opts, cb) { err.code = 'EDEPTYPE' if (!opts.error.EDEPTYPE) { - pkgs[depName] = {required: deps[depName], warn: err} + pkgs[depName] = { required: deps[depName], warn: err } } else { error = err } @@ -140,7 +140,7 @@ function getDependencies (manifest, opts, cb) { err.code = 'ESCM' if (!opts.error.ESCM) { - pkgs[depName] = {required: deps[depName], warn: err} + pkgs[depName] = { required: deps[depName], warn: err } } else { error = err } @@ -157,7 +157,7 @@ function getDependencies (manifest, opts, cb) { err.code = 'E404' } - pkgs[depName] = {required: deps[depName], warn: err} + pkgs[depName] = { required: deps[depName], warn: err } } else { error = err } diff --git a/test/cli.js b/test/cli.js index 0dc887b..93465d6 100644 --- a/test/cli.js +++ b/test/cli.js @@ -40,7 +40,7 @@ function runDavid (args, fixture, cb) { cp(fixturePkgPath, tmpPkgPath, function () { args = [davidPath].concat(args) - var opts = {cwd: path.join(tmpPath, fixture)} + var opts = { cwd: path.join(tmpPath, fixture) } var proc = childProcess.execFile('node', args, opts, cb) proc.stdout.pipe(process.stdout) diff --git a/test/david.js b/test/david.js index 13a9d1c..4641353 100644 --- a/test/david.js +++ b/test/david.js @@ -557,7 +557,7 @@ test('Test `npm view 0 versions` does not throw!', function (t) { Npm.__set__('npm', npmMock) - var manifest = {dependencies: ['0']} + var manifest = { dependencies: ['0'] } t.doesNotThrow(function () { david.getDependencies(manifest, function () {}) @@ -577,9 +577,9 @@ test('Test error whilst getting dependency status doesn\'t cause remaining proce view: function (args, silent, cb) { process.nextTick(function () { if (args[0] === 'testDepName') { - cb(null, {'0.0.1rc1': {versions: ['0.0.1rc1', '1.0.0'], time: [new Date().toISOString()]}}) + cb(null, { '0.0.1rc1': { versions: ['0.0.1rc1', '1.0.0'], time: [new Date().toISOString()] } }) } else { - cb(null, {'1.2.3': {versions: ['1.2.3'], time: [new Date().toISOString()]}}) + cb(null, { '1.2.3': { versions: ['1.2.3'], time: [new Date().toISOString()] } }) } }) } @@ -596,7 +596,7 @@ test('Test error whilst getting dependency status doesn\'t cause remaining proce } // Force and error to be returned by david, by specifying dependecy as invalid semver (but valid loose semver) - david.getDependencies(manifest, {loose: false}, function (err, deps) { + david.getDependencies(manifest, { loose: false }, function (err, deps) { t.ok(err) // An error object should have been passed back t.ok(deps) // A deps object containing only testDepName2 should have been passed back t.ok(!deps.testDepName) @@ -618,7 +618,7 @@ test('Return dependency versions when versions option is true', function (t) { commands: { view: function (args, silent, cb) { process.nextTick(function () { - cb(null, {'1.1.0': {versions: ['0.2.0', '1.0.1', '1.1.0']}}) + cb(null, { '1.1.0': { versions: ['0.2.0', '1.0.1', '1.1.0'] } }) }) } } @@ -632,7 +632,7 @@ test('Return dependency versions when versions option is true', function (t) { } } - david.getDependencies(manifest, {loose: true, versions: true}, function (err, deps) { + david.getDependencies(manifest, { loose: true, versions: true }, function (err, deps) { t.ifError(err) t.ok(deps) t.ok(deps.testDepName) @@ -655,7 +655,7 @@ test('Return dependency versions satisfying ranges when rangeVersions option is commands: { view: function (args, silent, cb) { process.nextTick(function () { - cb(null, {'1.1.0': {versions: ['0.2.0', '1.0.1', '1.1.0']}}) + cb(null, { '1.1.0': { versions: ['0.2.0', '1.0.1', '1.1.0'] } }) }) } } @@ -669,7 +669,7 @@ test('Return dependency versions satisfying ranges when rangeVersions option is } } - david.getDependencies(manifest, {loose: true, rangeVersions: true}, function (err, deps) { + david.getDependencies(manifest, { loose: true, rangeVersions: true }, function (err, deps) { t.ifError(err) t.ok(deps) t.ok(deps.testDepName) @@ -715,7 +715,7 @@ test('Test non-string dependency doesn\'t throw', function (t) { } } - david.getDependencies(manifest, {error: {EDEPTYPE: true}}, function (err) { + david.getDependencies(manifest, { error: { EDEPTYPE: true } }, function (err) { t.ok(err, 'Expected error') t.equal(err.code, 'EDEPTYPE', 'Expected error code EDEPTYPE') t.end() From fb9efe44370da205f939073a7616c8c173bca661 Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Mon, 5 Aug 2019 14:45:16 +0200 Subject: [PATCH 3/6] readme: remove gittip shield/badge --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index bc73297..1f24621 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,11 @@

David

npm version +Inline docs Build Status Coverage Status Dependency Status devDependency Status -Inline docs -Donate to help support David development

Node.js module that tells you when your package npm dependencies are out of date. From 1c0b424cc653bbcc8d1b4345be891e071f3e1a71 Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Mon, 5 Aug 2019 15:16:45 +0200 Subject: [PATCH 4/6] readme: centered footer --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 1f24621..e4d06d5 100644 --- a/README.md +++ b/README.md @@ -201,4 +201,6 @@ Release History --- -[![js-standard-style](https://cdn.rawgit.com/feross/standard/master/badge.svg)](https://github.com/feross/standard) +

+js-standard-style +

From 63c5a16b4ae3073bdda4e56e10f4059b5166fc22 Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Mon, 5 Aug 2019 15:03:51 +0200 Subject: [PATCH 5/6] readme: move 'Release History' to CHANGELOG.md --- CHANGELOG.md | 131 +++++++++++++++++++++++++++++++++++++++++++++++++++ README.md | 34 ------------- 2 files changed, 131 insertions(+), 34 deletions(-) create mode 100644 CHANGELOG.md diff --git a/CHANGELOG.md b/CHANGELOG.md new file mode 100644 index 0000000..272e4f5 --- /dev/null +++ b/CHANGELOG.md @@ -0,0 +1,131 @@ +# Changelog + +The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). + +## 11.0.0 - 2017-03-02 + +- Update dependencies + +## 10.0.0 - 2017-01-20 + +- Update to npm@4 + +## 9.0.0 - 2016-08-26 + +- CLI add global dependencies up to date message + +## 8.0.0 - 2016-06-30 + +- Update dependencies + +## 7.0.0 - 2015-11-09 + +- Update to npm@3 + +## 6.4.0 - 2015-10-19 + +- CLI Add `-i, --ignore` option to ignore dependencies + +## 6.3.0 - 2015-10-19 + +- Ignore dependencies from `package.json` config + +## 6.2.0 - 2015-08-08 + +- CLI Add `-p, --package` to specify package.json path + +## 6.0.0 - 2014-12-19 + +- Warn about unregistered or git dependencies by default + +## 5.0.0 - 2014-09-22 + +- Update to semver@4.0.0 + +## 4.1.0 - 2014-09-22 + +- Add versions option to return all dependency versions + +## 4.0.0 - 2014-09-21 + +- Update to npm@2.0.2, add rangeVersions option + +## 3.3.0 - 2014-06-02 + +- CLI Add `--warn404` option to print errors but not abort + +## 3.1.0 - 2014-03-11 + +- CLI Add `-r, --registry` option to use alternate npm registry + +## 3.0.0 - 2014-03-06 + +- Errors occurring whilst retrieving dependency status doesn't halt processing of other dependencies. +- An error object will be returned as first arg to callback, but status info for remaining dependencies will still be available (as second arg). +- CLI now uses loose semver version parsing. +- Update npm dependency so `david update` uses "^" as per https://github.com/npm/npm/issues/4587 + +## 2.4.0 - 2013-10-27 + +- Removes `semverext.js`. The `gtr` function is now available in `semver` + +## 2.3.0 - 2013-10-08 + +- Support update specific modules from CLI via `david update [module]` + +## 2.2.0 - 2013-10-01 + +- Support for `optionalDependencies` and `peerDependencies` + +## 2.1.0 - 2013-09-16 + +- Fixed issues with latest/stable version detection + +## 2.0.0 - 2013-08-25 + +- Simplification refactor to remove caching and useless events. +- Code style changes, performance improvements. + +## 1.9.0 - 2013-08-04 + +- CLI added `--unstable` flag to view/update to latest _unstable_ dependency versions + +## 1.8.0 - 2013-07-30 + +- CLI added `david update` to update dependencies to latest _stable_ versions and save to your project `package.json` + +## 1.7.0 - 2013-06-27 + +- Updated to use semver 2 module +- Simplified code that determines if a version is greater than a range + +## 1.6.0 - 2013-03-28 + +- Use `setImmediate` instead of `process.nextTick`. +- David now requires Node.js 0.10.x + +## 1.5.0 - 2013-03-27 + +- CLI added `--global` flag to find outdated global dependencies + +## 1.4.0 - 2013-03-15 + +- Allow set the maximum number of dependencies that can be stored in the cache + +## 1.3.0 - 2013-03-14 + +- Added CLI support + +## 1.2.0 - 2013-03-05 + +- David can now get dependency information for `devDependencies` + +## 1.1.0 - 2013-02-07 + +- Adds `onlyStable` param to `getUpdatedDependencies` to filter by dependencies that are updated and stable + +## 1.0.0 - 2013-02-06 + +- Return latest stable version as well as latest version (including patch and build versions). +- API return values changed. +- Events changed. diff --git a/README.md b/README.md index e4d06d5..bc56001 100644 --- a/README.md +++ b/README.md @@ -165,40 +165,6 @@ To tell david to ignore dependencies, add a `david.ignore` property to your `pac } ``` - -Release History ---------------- - -* 2017-01-20   v10.0.0   Update to npm@4 -* 2016-08-26   v9.0.0   CLI add global dependencies up to date message -* 2016-06-30   v8.0.0   Update dependencies -* 2015-11-09   v7.0.0   Update to npm@3 -* 2015-10-19   v6.4.0   CLI Add `-i, --ignore` option to ignore dependencies -* 2015-10-19   v6.3.0   Ignore dependencies from `package.json` config -* 2015-08-08   v6.2.0   CLI Add `-p, --package` to specify package.json path -* 2014-12-19   v6.0.0   Warn about unregistered or git dependencies by default -* 2014-09-22   v5.0.0   Update to semver@4.0.0 -* 2014-09-22   v4.1.0   Add versions option to return all dependency versions -* 2014-09-21   v4.0.0   Update to npm@2.0.2, add rangeVersions option -* 2014-06-02   v3.3.0   CLI Add `--warn404` option to print errors but not abort -* 2014-03-11   v3.1.0   CLI Add `-r, --registry` option to use alternate npm registry -* 2014-03-06   v3.0.0   Errors occurring whilst retrieving dependency status doesn't halt processing of other dependencies. An error object will be returned as first arg to callback, but status info for remaining dependencies will still be available (as second arg). CLI now uses loose semver version parsing. Also update npm dependency so `david update` uses "^" as per https://github.com/npm/npm/issues/4587 -* 2013-10-27   v2.4.0   Removes `semverext.js`. The `gtr` function is now available in `semver` -* 2013-10-08   v2.3.0   Support update specific modules from CLI via `david update [module]` -* 2013-10-01   v2.2.0   Support for `optionalDependencies` and `peerDependencies` -* 2013-09-16   v2.1.0   Fixed issues with latest/stable version detection -* 2013-08-25   v2.0.0   Simplification refactor to remove caching and useless events. Code style changes, performance improvements. -* 2013-08-04   v1.9.0   CLI added `--unstable` flag to view/update to latest _unstable_ dependency versions -* 2013-07-30   v1.8.0   CLI added `david update` to update dependencies to latest _stable_ versions and save to your project `package.json` -* 2013-06-27   v1.7.0   Updated to use semver 2 module. Simplified code that determines if a version is greater than a range -* 2013-03-28   v1.6.0   Use `setImmediate` instead of `process.nextTick`. David now requires Node.js 0.10.x -* 2013-03-27   v1.5.0   CLI added `--global` flag to find outdated global dependencies -* 2013-03-15   v1.4.0   Allow set the maximum number of dependencies that can be stored in the cache -* 2013-03-14   v1.3.0   Added CLI support -* 2013-03-05   v1.2.0   David can now get dependency information for `devDependencies` -* 2013-02-07   v1.1.0   Adds `onlyStable` param to `getUpdatedDependencies` to filter by dependencies that are updated and stable -* 2013-02-06   v1.0.0   Return latest stable version as well as latest version (including patch and build versions). API return values changed. Events changed. - ---

From 13b19f761db216c72a76bceaa860999659a490d3 Mon Sep 17 00:00:00 2001 From: 1138-4EB <1138-4EB@users.noreply.github.com> Date: Mon, 5 Aug 2019 13:57:30 +0200 Subject: [PATCH 6/6] fix failing tests --- test/cli.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/test/cli.js b/test/cli.js index 93465d6..8c6fd46 100644 --- a/test/cli.js +++ b/test/cli.js @@ -166,9 +166,9 @@ test('Test print-only output with unregistered dependency in each type', functio t.ok(new RegExp(depName, 'm').test(stdout.toString()), depName + ' expected to be outdated') }) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistered--/m.test(stdout.toString())) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistereddev--/m.test(stdout.toString())) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregisteredopt--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistered--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistereddev--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregisteredopt--/m.test(stdout.toString())) t.end() }) @@ -180,9 +180,9 @@ test('Test default exit response to unregistered dependency', function (t) { runDavid([], 'test-unregistered', function (err, stdout) { // There are dependencies to be updated, so we expect non zero exit code t.ok(err.code, 'Exited with non zero exit code') - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistered--/m.test(stdout.toString())) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistereddev--/m.test(stdout.toString())) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregisteredopt--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistered--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistereddev--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregisteredopt--/m.test(stdout.toString())) t.end() }) }) @@ -223,9 +223,9 @@ test('Test update with unregistered dependency in each type', function (t) { t.notEqual(pkg.optionalDependencies[depName], updatedPkg.optionalDependencies[depName], depName + ' version expected to have changed') }) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistered--/m.test(stdout.toString())) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistereddev--/m.test(stdout.toString())) - t.ok(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregisteredopt--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistered--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregistereddev--/m.test(stdout.toString())) + t.notOk(/Error: Registry returned 404 for GET on https:\/\/registry.npmjs.org\/unregisteredopt--/m.test(stdout.toString())) t.end() })