Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect_num breaks when column is all NAs #18

Closed
ryanatanner opened this issue Aug 26, 2019 · 2 comments
Closed

inspect_num breaks when column is all NAs #18

ryanatanner opened this issue Aug 26, 2019 · 2 comments

Comments

@ryanatanner
Copy link

@ryanatanner ryanatanner commented Aug 26, 2019

Thanks for the great package; I noticed that the inspect_num function hits an error when hist gets a column with exclusively NAs, like this.

inspect_num(data.frame(a = 1:100, b = rep(NA_real_, 100)))

Here's the error I'm seeing:

Error in hist.default(df_num[[breaks_tbl$col_name[i]]], plot = FALSE,  :    character(0)
In addition: Warning messages: 
1: In min(value, na.rm = T) :   no non-missing arguments to min; returning Inf 
2: In max(value, na.rm = T) :   no non-missing arguments to max; returning -Inf

Cheers!

@alastairrushworth
Copy link
Owner

@alastairrushworth alastairrushworth commented Aug 26, 2019

Thanks so much for the report @ryanatanner! This has now been fixed in the dev version. I'll get an update to the CRAN version shortly.

@ryanatanner
Copy link
Author

@ryanatanner ryanatanner commented Aug 28, 2019

Thank you! Such a fast response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.