Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic sizing for text (#5) #9

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@wilkox
Copy link
Contributor

@wilkox wilkox commented Jun 24, 2019

Add automatic text sizing using ggfittext, as suggested in #5. The example plots in the README now look like this:









@codecov-io
Copy link

@codecov-io codecov-io commented Jun 24, 2019

Codecov Report

Merging #9 into master will increase coverage by 0.13%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   92.43%   92.57%   +0.13%     
==========================================
  Files          39       39              
  Lines        1111     1104       -7     
==========================================
- Hits         1027     1022       -5     
+ Misses         84       82       -2
Impacted Files Coverage Δ
R/bar_plot.R 90.9% <ø> (ø) ⬆️
R/plot_types.R 33.33% <0%> (+1.33%) ⬆️
R/plot_num.R 96.42% <100%> (+0.08%) ⬆️
R/plot_imb.R 100% <100%> (ø) ⬆️
R/plot_cat.R 99.09% <100%> (-0.01%) ⬇️
R/add_annotation_to_bars.R 100% <100%> (ø) ⬆️
R/plot_mem.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ed535...aee5111. Read the comment docs.

@alastairrushworth alastairrushworth merged commit 5a69afc into alastairrushworth:master Jun 24, 2019
3 checks passed
3 checks passed
codecov/patch 93.75% of diff hit (target 92.43%)
Details
codecov/project 92.57% (+0.13%) compared to c7ed535
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alastairrushworth
Copy link
Owner

@alastairrushworth alastairrushworth commented Jun 24, 2019

Hi @wilkox thanks for this PR, I really like the ggfittext package, I think this is a great feature! I have now merged this into master. I might make a few follow-up edits to make sure the defaults make sense etc, but I think things look great.

I'll add a line in the NEWS.md file crediting the change to you. Let me know if there is any other way you'd expect to be credited (this is the first PR I've merged!).

@wilkox
Copy link
Contributor Author

@wilkox wilkox commented Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.