Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd partial/split render methods to allow usage with restrictive javascript frameworks. #79
Conversation
danmatthews
added some commits
Apr 4, 2018
This comment has been minimized.
This comment has been minimized.
Whoops! I'll fix these conflicts shortly. |
Jamesking56
suggested changes
Jun 28, 2018
Jamesking56 left a comment
The |
You can render the polyfill (do this somewhere like the head of your HTML:) | ||
|
||
```php | ||
{!! app('captcha')->renderPolyfill(); !!} |
This comment has been minimized.
This comment has been minimized.
@@ -1,9 +1,13 @@ | |||
{ | |||
"name": "albertcht/invisible-recaptcha", | |||
"name": "danmatthews/invisible-recaptcha", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danmatthews
Jun 28, 2018
Author
Contributor
Hi @Jamesking56 - yep i created it to temporarily publish for use in a production app, will remove.
This comment has been minimized.
This comment has been minimized.
Hi @danmatthews , Thanks for your pull request. Sorry for the late reply because recently I'm busy working on another project. I will follow this PR and review the code as soon as possible. Thanks again! |
This comment has been minimized.
This comment has been minimized.
@albertcht no problem, i still need to remove that composer.json change. |
This comment has been minimized.
This comment has been minimized.
Jamesking56
commented
Sep 6, 2018
@danmatthews Any update for this? |
This comment has been minimized.
This comment has been minimized.
SPQRInc
commented
Jan 11, 2019
I am really waiting for this ;-) |
danmatthews
added some commits
Jan 11, 2019
This comment has been minimized.
This comment has been minimized.
Hey Guys, i've removed the blockers, but i've had half a bottle of wine, so forgive me if i've made some stupid mistake, i'll double-check this tomorrow. Sorry for the delay! |
This comment has been minimized.
This comment has been minimized.
SPQRInc
commented
Jan 12, 2019
Thank you. Can't wait for the merge :-) |
albertcht
merged commit 37d45f0
into
albertcht:master
Jan 26, 2019
This comment has been minimized.
This comment has been minimized.
Thanks for this PR, I will release a new version after I do the final review :) |
This comment has been minimized.
This comment has been minimized.
SPQRInc
commented
Feb 10, 2019
Sounds great! Can't wait for it. Thank you for your work! |
danmatthews commentedApr 4, 2018
This request just splits out the render method into completely optional separate methods and directives which can be used to pull the script tags out of the main
<form>
- allowing you to use this with VueJS and any other HTML template based Javascript framework that might restrict script tags in the template.