New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial/split render methods to allow usage with restrictive javascript frameworks. #79

Merged
merged 7 commits into from Jan 26, 2019

Conversation

Projects
None yet
4 participants
@danmatthews
Copy link
Contributor

danmatthews commented Apr 4, 2018

This request just splits out the render method into completely optional separate methods and directives which can be used to pull the script tags out of the main <form> - allowing you to use this with VueJS and any other HTML template based Javascript framework that might restrict script tags in the template.

danmatthews added some commits Apr 4, 2018

Adds partial render methods and corresponding blade directives for fr…
…ameworks that don't support script tags in templates
@danmatthews

This comment has been minimized.

Copy link
Contributor Author

danmatthews commented Jun 27, 2018

Whoops! I'll fix these conflicts shortly.

@Jamesking56
Copy link

Jamesking56 left a comment

The composer.json change is breaking and needs removing before merge.

README.md Outdated
You can render the polyfill (do this somewhere like the head of your HTML:)

```php
{!! app('captcha')->renderPolyfill(); !!}

This comment has been minimized.

@Jamesking56

Jamesking56 Jun 28, 2018

Don't need the ; (and other lines similar below)

@@ -1,9 +1,13 @@
{
"name": "albertcht/invisible-recaptcha",
"name": "danmatthews/invisible-recaptcha",

This comment has been minimized.

@Jamesking56

Jamesking56 Jun 28, 2018

This shouldn't be included in the PR.

This comment has been minimized.

@danmatthews

danmatthews Jun 28, 2018

Author Contributor

Hi @Jamesking56 - yep i created it to temporarily publish for use in a production app, will remove.

@albertcht

This comment has been minimized.

Copy link
Owner

albertcht commented Jun 28, 2018

Hi @danmatthews ,

Thanks for your pull request. Sorry for the late reply because recently I'm busy working on another project.

I will follow this PR and review the code as soon as possible. Thanks again!

@danmatthews

This comment has been minimized.

Copy link
Contributor Author

danmatthews commented Jun 28, 2018

@albertcht no problem, i still need to remove that composer.json change.

@Jamesking56

This comment has been minimized.

Copy link

Jamesking56 commented Sep 6, 2018

@danmatthews Any update for this?

@SPQRInc

This comment has been minimized.

Copy link

SPQRInc commented Jan 11, 2019

I am really waiting for this ;-)

danmatthews added some commits Jan 11, 2019

@danmatthews

This comment has been minimized.

Copy link
Contributor Author

danmatthews commented Jan 11, 2019

Hey Guys, i've removed the blockers, but i've had half a bottle of wine, so forgive me if i've made some stupid mistake, i'll double-check this tomorrow. Sorry for the delay!

@SPQRInc

This comment has been minimized.

Copy link

SPQRInc commented Jan 12, 2019

Thank you. Can't wait for the merge :-)

@albertcht albertcht merged commit 37d45f0 into albertcht:master Jan 26, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@albertcht

This comment has been minimized.

Copy link
Owner

albertcht commented Jan 26, 2019

Thanks for this PR, I will release a new version after I do the final review :)

@SPQRInc

This comment has been minimized.

Copy link

SPQRInc commented Feb 10, 2019

Sounds great! Can't wait for it. Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment